Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-5006

Get CiBot to check 132 char line length first

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.6.2
    • Fix Version/s: None
    • Component/s: Local: Code checker
    • Labels:
      None
    • Affected Branches:
      MOODLE_26_STABLE

      Description

      In MDL-43669, I submitted a patch and CiBot came back with an issue saying that one of the lines was over the 180 character maximum limit. I fixed this and resubmitted and CiBot then started complaining about the 132 character limit (see the comments in the issue). (It's worth mentioning that the 132 character limit didn't also appear in the original report).

      I understand that this is happening because the code checker has 180 characters as the hard limit, and gives a warning if it's over 132, but given that the bot doesn't seem to differentiate between warnings and failures, it would be much better if the 132 character rule were to take precedence over the 180 character one.

      It's not a big deal, but it was a bit of a pain to have to fix the line lengths and fix them again, so it might help to keep community developers engaged if this could be changed.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: