Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-5214

View patterns by view name (e.g. ##viewlink:<viewname>##) are not processed in acceptance tests.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.4, 2.7.1
    • Fix Version/s: 2.6.4, 2.7.1
    • Component/s: Set: Dataform
    • Labels:
      None
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE

      Description

      View patterns by view name (e.g. ##viewlink:<viewname>##) are not processed in acceptance tests.

      Apparently this is because view_manager::get_views_menu() that is called for generating the patterns for all existing views, uses a static variable to store the menu, and since the acceptance test is essentially a run of one script, this static variable is set once empty on an earlier call and never get updated.

      A fix removes the static variable, to the effect that there is a DB access every time the view_manager::get_views_menu() is called. To reduce these DB accesses, simple caches should be implemented as needed where this method is called.

        Attachments

          Activity

            People

            • Assignee:
              itamart Itamar Tzadok
              Reporter:
              itamart Itamar Tzadok
              Tester:
              Itamar Tzadok
              Participants:
              Component watchers:
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jul/14