Add-ons
  1. Add-ons
  2. CONTRIB-528

Quiz UI redesign, based on usability research

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Add a project here
    • Labels:
      None
    • Rank:
      24674

      Description

      http://docs.moodle.org/en/Development:Quiz_Usability_portal
      http://docs.moodle.org/en/Development:Quiz_UI_redesign#Development

      As part of this Summer Code [1] project, usability research has been carried out since May 2007 and more actively during April, May, June 2008. Scenario interviews have been carried out and taken to the UI design, an Openoffice Impress prototype has iteratively designed and usability tested with eight subjects from four different educational institutions in Finland. The spec will be published on June 27th, 2008 at http://docs.moodle.org/en/Development:Quiz_UI_redesign_-_Design_specification , as well as in the Quiz forums.

      The project blog is at at http://www.pilpi.net/software/moodle_quiz_ui/

      This is the root Tracker Issue (hope I have correctly understood the usage of this tracker , under which development tasks will be gathered. Also CVS access is requested, with the initial files of the contents of the PHP/ directory in the zip attachment.

      The attached files in the directory PHP/ of the zip package have been edited to provide as the basis on which development will continue during July and August 2008. They are edited Moodle 1.9 weekly build files, downloaded from download.moodle.org on June 26th, 2008. They are to be extracted to /mod/quiz and the browser pointed to /mod/quiz/edit_redesign.php?cmid=2 with the proper course module id as a parameter. (Note: moodle_quiz_ui_proto_0.1b.zip contains the current version, moodle_quiz_ui_proto_0.1.zip is missing the actual edit.php redesigned version.)

      Also attached is demo.html (graphics are missing though and it looks a bit cryptic), which roughly shows the current state of actual PHP development as a static file, when extracted to the same directory with the directory demo_files .

      [1] http://www.coss.fi/web/coss/developers/summercode/2008?p_p_id=82&p_p_action=1&p_p_state=normal&p_p_mode=view&p_p_col_id=null&p_p_col_pos=4&p_p_col_count=5&_82_struts_action=%2Flanguage%2Fview&languageId=en_US

      1. 2008-11-04_css.diff
        14 kB
        Olli Savolainen
      2. 2008-11-04.diff
        149 kB
        Olli Savolainen
      3. 2008-11-27_moodle2cvshead.zip
        44 kB
        Olli Savolainen
      4. moodle_quiz_ui_proto_0.50.zip
        165 kB
        Olli Savolainen
      5. moodle_quiz_ui_proto_0.51.zip
        56 kB
        Olli Savolainen
      6. moodle_quiz_ui_proto_0.6-2008-10-15.zip
        41 kB
        Olli Savolainen
      1. icon.gif
        0.1 kB

        Issue Links

          Activity

          Hide
          Olli Savolainen added a comment -

          The current version, if you can't view the static mht file, read mht-readme.txt.

          Show
          Olli Savolainen added a comment - The current version, if you can't view the static mht file, read mht-readme.txt.
          Hide
          Olli Savolainen added a comment -

          what was changed in question/ is in the diff, the other files are just to be added in mod/quiz/ for now.

          Show
          Olli Savolainen added a comment - what was changed in question/ is in the diff, the other files are just to be added in mod/quiz/ for now.
          Hide
          Olli Savolainen added a comment -

          diffs and separate files for current changes from moodle 1.9

          Show
          Olli Savolainen added a comment - diffs and separate files for current changes from moodle 1.9
          Hide
          Olli Savolainen added a comment -

          This time, just the diff + one gif file + the lang files from moodledata

          Show
          Olli Savolainen added a comment - This time, just the diff + one gif file + the lang files from moodledata
          Hide
          Tim Hunt added a comment -

          Drat! I can't get the patch to apply. Well, it is nearly time to go home here anyway, so I don't have time to look at the code now, but I was hoping to get the merge done now so I could start looking first thing in the morning.

          It is not happy with weblib, I think because of whitespace differerences.

          More seriously, there are files like editlib_redesign.php where the patch contains changes, but 1.9 does not have a file of that name.

          Apart from that the patch works (once I have selected reverse). Could you try regenerating the patch, then I will try to have a look tomorrow. Thanks.

          Show
          Tim Hunt added a comment - Drat! I can't get the patch to apply. Well, it is nearly time to go home here anyway, so I don't have time to look at the code now, but I was hoping to get the merge done now so I could start looking first thing in the morning. It is not happy with weblib, I think because of whitespace differerences. More seriously, there are files like editlib_redesign.php where the patch contains changes, but 1.9 does not have a file of that name. Apart from that the patch works (once I have selected reverse). Could you try regenerating the patch, then I will try to have a look tomorrow. Thanks.
          Hide
          Olli Savolainen added a comment -

          Yes, there are some additional files. Since the original where I created the patch from does not contain the _redesign files, I figured patch would just create those files. But I'll create another package with also separate files.

          Eclipse seems to want to forcibly add strange whitespace into weblib.php. I will look into that, too later today. (It's 13:20 here so plenty time).

          Show
          Olli Savolainen added a comment - Yes, there are some additional files. Since the original where I created the patch from does not contain the _redesign files, I figured patch would just create those files. But I'll create another package with also separate files. Eclipse seems to want to forcibly add strange whitespace into weblib.php. I will look into that, too later today. (It's 13:20 here so plenty time).
          Hide
          Tim Hunt added a comment -

          The strange thing is that most of the new files did appear in the patch OK, it was just a few where they didn't.

          Show
          Tim Hunt added a comment - The strange thing is that most of the new files did appear in the patch OK, it was just a few where they didn't.
          Hide
          Olli Savolainen added a comment - - edited

          I am sorry indeed. It seems that revision 1 in my subversion repository (against witch the previous patch was made) was not clean moodle 1.9 after all. Now I have tested the new version 0.52 to patch against fresh 1.9, see notes.txt. I also made some fixes based on the usability tests already, now that I got started - more is still to come, though.

          • Emphasized the question bank title, since in contrast with the earlier OOo prototype tests, now the whole right side of the screen often went completely unnoticed and frustrated users in tests
          • Made reorganize a subtab of edit
          • Made essay question icon resemble a checkbox less, since it confused a lot of users in tests

          Also, fixed IE 6 to display properly, just had to fix two things in CSS and no quirks were required. However, everything related to javascript is broken on IE 6 at the moment: IE6 only seems to show one error message: Line 67 Char 22: Expected identifier, string or number. So the "add question" dropdown does not work. When I remove the new YUI javascript however everything works, so there is a conflict of some kind (though not if used in firefox). One thing that might help is to move also the new javascript to <head>, it is now in <body>. This error seems to vary between page loads or something though; in any case, the YUI random question adding dialog does not work.

          On the other hand, it seems that Moodle does not support IE 5 at all: the login form does not appear on the login page so I could not test it.

          Show
          Olli Savolainen added a comment - - edited I am sorry indeed. It seems that revision 1 in my subversion repository (against witch the previous patch was made) was not clean moodle 1.9 after all. Now I have tested the new version 0.52 to patch against fresh 1.9, see notes.txt. I also made some fixes based on the usability tests already, now that I got started - more is still to come, though. Emphasized the question bank title, since in contrast with the earlier OOo prototype tests, now the whole right side of the screen often went completely unnoticed and frustrated users in tests Made reorganize a subtab of edit Made essay question icon resemble a checkbox less, since it confused a lot of users in tests Also, fixed IE 6 to display properly, just had to fix two things in CSS and no quirks were required. However, everything related to javascript is broken on IE 6 at the moment: IE6 only seems to show one error message: Line 67 Char 22: Expected identifier, string or number. So the "add question" dropdown does not work. When I remove the new YUI javascript however everything works, so there is a conflict of some kind (though not if used in firefox). One thing that might help is to move also the new javascript to <head>, it is now in <body>. This error seems to vary between page loads or something though; in any case, the YUI random question adding dialog does not work. On the other hand, it seems that Moodle does not support IE 5 at all: the login form does not appear on the login page so I could not test it.
          Hide
          Olli Savolainen added a comment -

          Just to make sure you can use something, Tim, here is everything I have done as separate files, too.

          Show
          Olli Savolainen added a comment - Just to make sure you can use something, Tim, here is everything I have done as separate files, too.
          Hide
          Tim Hunt added a comment -

          Just to let you know, that latest patch applies.

          Show
          Tim Hunt added a comment - Just to let you know, that latest patch applies.
          Hide
          Tim Hunt added a comment -

          Some review comments:

          1. Do you develop with Administration ? Server ? Debugging > Debug messages set to DEVELOPER, and Display debug messages turned on? You should. I do, and am seeing PHP notices displayed, and that is making it very hard to test. Also, some of the notices seem to be pointing out real bugs.

          2. Please try to keep the code wrapped at about 80 colums wide. It makes it easier to read, and when you wrap a line, double-indent the following lines (8 spaces) to try to give some clue that it is a continuation.

          3. Line 249 of mod/quiz/edit.php (an example of a line that is too long!) refers to $param->..., but I can't see where this is defined. Looking at the code being called, these parameters don't seem to be used. Oh ...

          4. I did not know about the PHP compact function. It looks dangerous to me, because it makes it hard to see where a variable like $currentcat is used. I would stick to the more verbose array('currentcat' => $currentcat, 'contexts' => $contexts);

          5. And it is this undefined variable that is giving me SQL errors like

          ERROR: syntax error at or near "AND" LINE 1: ...ies c1, s19_question_categories c2 WHERE c2.id = AND c1.con... ^

          SELECT count FROM s19_question_categories c1, s19_question_categories c2 WHERE c2.id = AND c1.contextid = c2.contextid

          I am on PHP 5.2.4 and PostgreSQL here.

          6. <link> tags should use the short-tag syntax: <link ... />, instead of <link></link>.

          7. The way to get extra stuff, like links to stylesheets, included in <head>, is to pass extra HTML as the 5th ($meta) parameter to print_header_simple.

          8. You probably need to change your print_box_start(); call around line 570 of edit.php to print_box_start('generalbox clearfix');

          9. It still lets me add questions even though the "You cannot add or remove questions because there are attempts." message is displayed. Also, when that message is displayed, the stylesheet is not used so the layout is messed up.

          I'm going to stop reviewing there for now. Sorry that a lot of these points are trivial. The key ones to fix are 1. and 9. It would be a lot easier to carry on reviewing if these are fixed.

          Show
          Tim Hunt added a comment - Some review comments: 1. Do you develop with Administration ? Server ? Debugging > Debug messages set to DEVELOPER, and Display debug messages turned on? You should. I do, and am seeing PHP notices displayed, and that is making it very hard to test. Also, some of the notices seem to be pointing out real bugs. 2. Please try to keep the code wrapped at about 80 colums wide. It makes it easier to read, and when you wrap a line, double-indent the following lines (8 spaces) to try to give some clue that it is a continuation. 3. Line 249 of mod/quiz/edit.php (an example of a line that is too long!) refers to $param->..., but I can't see where this is defined. Looking at the code being called, these parameters don't seem to be used. Oh ... 4. I did not know about the PHP compact function. It looks dangerous to me, because it makes it hard to see where a variable like $currentcat is used. I would stick to the more verbose array('currentcat' => $currentcat, 'contexts' => $contexts); 5. And it is this undefined variable that is giving me SQL errors like ERROR: syntax error at or near "AND" LINE 1: ...ies c1, s19_question_categories c2 WHERE c2.id = AND c1.con... ^ SELECT count FROM s19_question_categories c1, s19_question_categories c2 WHERE c2.id = AND c1.contextid = c2.contextid I am on PHP 5.2.4 and PostgreSQL here. 6. <link> tags should use the short-tag syntax: <link ... />, instead of <link></link>. 7. The way to get extra stuff, like links to stylesheets, included in <head>, is to pass extra HTML as the 5th ($meta) parameter to print_header_simple. 8. You probably need to change your print_box_start(); call around line 570 of edit.php to print_box_start('generalbox clearfix'); 9. It still lets me add questions even though the "You cannot add or remove questions because there are attempts." message is displayed. Also, when that message is displayed, the stylesheet is not used so the layout is messed up. I'm going to stop reviewing there for now. Sorry that a lot of these points are trivial. The key ones to fix are 1. and 9. It would be a lot easier to carry on reviewing if these are fixed.
          Hide
          Olli Savolainen added a comment -

          Huh, I was trying to set debugging on all along on the server, and couldn't so far make ubuntu do the PHP logging to /var/log/php.log where I have gotten used to seeing it. Didn't come to think that it might be in the actual panel. Sorry to have you test at this point, you could've just said the first point I guess :o).

          Anyway, thanks for the generous input. It isn't like I did not expect issues like this to pop up, however. As my schedule is tight and the focus is on user interaction, making everything solid on the backend can only be done once the interaction looks like it really matches the users' needs, since before that virtually anything can change.

          So, the question again is: How does the process of evaluating the entire project proceed? When would you expect to know positively if you can take my work into core? My current funding is about to end but I am committed to making this a finished package. However, I am a bit unease with the feeling that I have no guarantee at all from Moodle's side at this point that any of this stuff will be used, and as mentioned, www.coss.fi people would like to hear something, as well.

          Some replies:
          7. Oh. I used to do that, but the parameter name kinda implies it's for <meta> tags so I thought it's not ok .

          9. Will fix. I'm happy you brought up the subject of "You cannot add or remove questions because there are attempts", since this is a real issue with multiple faces. This came up in the usability tests, too: teachers are used to try everything in student role to preview. However, this way of previewing normally locks the quiz up, and the undo - deleting all attempts - is everything but obvious. So this is quite a usability disaster. This is not really much of a change in the UI but something that could be automated or the user, as follows. I think this would be of tremendous benefit, as also various messages in the quiz forum show this is a real issue - do you think we could get something like the following done?

          1. Always warn the user if the are about to do something that affects the set of choices they can make later (User control and freedom), and as the undo here is not obvious, tell the user about it
          2. Make the user aware of the choices they have in the quiz edit screens, where their actions' consequences are the most obvious:
          "The quiz has been <a href="attempts listing">attempted</a>, so you cannot edit it. You can still edit the questions in categories, so if you have random questions you can change the contents of those. If you need to modify the quiz, you can:

          • <a href="do it, but confirm">Delete all the attempts of this quiz</a>
          • <a href="do it, but confirm">Export the attempts</a> from the quiz to a static (HTML? XML? separate db table?) file. This will mean that you will be able to view those attempts, but will not be able to grade them within the quiz.
          • <a href="do it, but confirm">Make a copy of the quiz</a>, after which you can delete all the attempts from one of the quizzes and still keep grading functional.

          http://www.useit.com/papers/heuristic/heuristic_list.html

          Show
          Olli Savolainen added a comment - Huh, I was trying to set debugging on all along on the server, and couldn't so far make ubuntu do the PHP logging to /var/log/php.log where I have gotten used to seeing it. Didn't come to think that it might be in the actual panel. Sorry to have you test at this point, you could've just said the first point I guess :o). Anyway, thanks for the generous input. It isn't like I did not expect issues like this to pop up, however. As my schedule is tight and the focus is on user interaction, making everything solid on the backend can only be done once the interaction looks like it really matches the users' needs, since before that virtually anything can change. So, the question again is: How does the process of evaluating the entire project proceed? When would you expect to know positively if you can take my work into core? My current funding is about to end but I am committed to making this a finished package. However, I am a bit unease with the feeling that I have no guarantee at all from Moodle's side at this point that any of this stuff will be used, and as mentioned, www.coss.fi people would like to hear something, as well. Some replies: 7. Oh. I used to do that, but the parameter name kinda implies it's for <meta> tags so I thought it's not ok . 9. Will fix. I'm happy you brought up the subject of "You cannot add or remove questions because there are attempts", since this is a real issue with multiple faces. This came up in the usability tests, too: teachers are used to try everything in student role to preview. However, this way of previewing normally locks the quiz up, and the undo - deleting all attempts - is everything but obvious. So this is quite a usability disaster. This is not really much of a change in the UI but something that could be automated or the user, as follows. I think this would be of tremendous benefit, as also various messages in the quiz forum show this is a real issue - do you think we could get something like the following done? 1. Always warn the user if the are about to do something that affects the set of choices they can make later (User control and freedom), and as the undo here is not obvious, tell the user about it 2. Make the user aware of the choices they have in the quiz edit screens, where their actions' consequences are the most obvious: "The quiz has been <a href="attempts listing">attempted</a>, so you cannot edit it. You can still edit the questions in categories, so if you have random questions you can change the contents of those. If you need to modify the quiz, you can: <a href="do it, but confirm">Delete all the attempts of this quiz</a> <a href="do it, but confirm">Export the attempts</a> from the quiz to a static (HTML? XML? separate db table?) file. This will mean that you will be able to view those attempts, but will not be able to grade them within the quiz. <a href="do it, but confirm">Make a copy of the quiz</a>, after which you can delete all the attempts from one of the quizzes and still keep grading functional. http://www.useit.com/papers/heuristic/heuristic_list.html
          Hide
          Tim Hunt added a comment -

          I completely agree with you about the underlying usability issue with 9, although we could delete details of the solution.

          For now, I will just turn down debugging temporarily and review it some more.

          Show
          Tim Hunt added a comment - I completely agree with you about the underlying usability issue with 9, although we could delete details of the solution. For now, I will just turn down debugging temporarily and review it some more.
          Hide
          Olli Savolainen added a comment -

          Yeah, I guess options to just

          • delete the attempts, or
          • if there are actual student attempts make a copy of the quiz without the attempts

          would suffice.

          Still, hiding the quiz contents when there are attempts is not an option, just editing needs to be disabled. Also, since understanding what kinds of attempts there are is key to making the decision of whether the attempts can be deleted, there is a chance to make the interaction really fluid here by providing that information exactly where the decision is to be made.

          Show
          Olli Savolainen added a comment - Yeah, I guess options to just delete the attempts, or if there are actual student attempts make a copy of the quiz without the attempts would suffice. Still, hiding the quiz contents when there are attempts is not an option, just editing needs to be disabled. Also, since understanding what kinds of attempts there are is key to making the decision of whether the attempts can be deleted, there is a chance to make the interaction really fluid here by providing that information exactly where the decision is to be made.
          Hide
          Olli Savolainen added a comment -

          During the idle hours of the evening I couldn't resist the temptation but to look at the notices. Everything else I found at a glance was easy to fix, but the SQL error puzzles me. Seems that I don't know how to use question_category_object and the commenting seems scarce. I will look into it later more, now just to let you know.

          $qcobject = new question_category_object(
          $pagevars['cpage'],
          $thispageurl,
          $contexts->having_one_edit_tab_cap('categories'),
          null, /this still causes an error, somewhere it is using this in SQL unquoted, so if this is "x", you get Unknown column 'x' in 'where clause' - SELECT count FROM mdl_question_categories c1, mdl_question_categories c2 WHERE c2.id = x AND c1.contextid = c2.contextid/
          $pagevars['cat'],
          null, *// also changed this
          $contexts->having_cap('moodle/question:add'));

          Show
          Olli Savolainen added a comment - During the idle hours of the evening I couldn't resist the temptation but to look at the notices. Everything else I found at a glance was easy to fix, but the SQL error puzzles me. Seems that I don't know how to use question_category_object and the commenting seems scarce. I will look into it later more, now just to let you know. $qcobject = new question_category_object( $pagevars ['cpage'] , $thispageurl, $contexts->having_one_edit_tab_cap('categories'), null, / this still causes an error, somewhere it is using this in SQL unquoted, so if this is "x", you get Unknown column 'x' in 'where clause' - SELECT count FROM mdl_question_categories c1, mdl_question_categories c2 WHERE c2.id = x AND c1.contextid = c2.contextid / $pagevars ['cat'] , null, *// also changed this $contexts->having_cap('moodle/question:add'));
          Hide
          Olli Savolainen added a comment -

          Actually, I did not know about compact() before you introduced it to me, either. Ah yes, I seem to have copied the latter line from the earlier line here verbatim:

          $this->catform = new question_category_edit_form($this->pageurl, compact('contexts', 'currentcat'));
          $this->catform_rand = new question_category_edit_form_randomquestion($this->pageurl, compact('contexts', 'currentcat'));

          I, too, think it is worth changing to standard array() call.

          Show
          Olli Savolainen added a comment - Actually, I did not know about compact() before you introduced it to me, either. Ah yes, I seem to have copied the latter line from the earlier line here verbatim: $this->catform = new question_category_edit_form($this->pageurl, compact('contexts', 'currentcat')); $this->catform_rand = new question_category_edit_form_randomquestion($this->pageurl, compact('contexts', 'currentcat')); I, too, think it is worth changing to standard array() call.
          Hide
          Tim Hunt added a comment -

          I certainly did not write the compact call, since I had to look it up to find out what it did! CVS blames Jamie Anyway to more serious topics.

          I have been using the interface some more this morning, and I really like it. There are a couple of parts I have questions about, so hopefully we can hook up on Skype some time today and talk about it.

          But the big question is, should this be included in Moodle 2.0? That is a big question, so we need to break it down a bit.

          1. Is this the right direction for the Moodle quiz user interface to evolve? And do we have a consensus about the answer?

          2. Is the code quality good enough to be included in Moodle 2.0? That is does it follow the coding guidelines, and does it look like it is maintainable?

          2a. If not, about how much more work needs to be done?

          3. Does it meet all the necessary accessibility standards? For example, does it work with JavaScript turned off? Is it all valid HTML? Is it all usable just with the keyboard, no mouse?

          4. How much time to you have to commit to this project from now on? In particular from now until we think everything is finished, and then later when 2.0 is in beta?

          My opinions about the answers to these questions are:

          1. Yes. It immediately improves the current interface, and it probably makes it easier to add some of the future enhancements that have been talked about. There are some parts that need to be improved further, for example doing the re-ordering using drag and drop, but we can release what we have now, it is good enough, and make further improvements later.

          On the consensus subject, I will start another thread in the quiz forum in a moment. Annoyingly, Martin D is still on holiday at the Olympics, so I won't be able to discuss this with him until Monday, which is bad timing.

          2. I would like to review the code some more. I have mostly been focussing on using the functionality in my recent testing.

          For the remaining questions, your probably have a better idea than me, hence the fact it would be good to talk.

          Show
          Tim Hunt added a comment - I certainly did not write the compact call, since I had to look it up to find out what it did! CVS blames Jamie Anyway to more serious topics. I have been using the interface some more this morning, and I really like it. There are a couple of parts I have questions about, so hopefully we can hook up on Skype some time today and talk about it. But the big question is, should this be included in Moodle 2.0? That is a big question, so we need to break it down a bit. 1. Is this the right direction for the Moodle quiz user interface to evolve? And do we have a consensus about the answer? 2. Is the code quality good enough to be included in Moodle 2.0? That is does it follow the coding guidelines, and does it look like it is maintainable? 2a. If not, about how much more work needs to be done? 3. Does it meet all the necessary accessibility standards? For example, does it work with JavaScript turned off? Is it all valid HTML? Is it all usable just with the keyboard, no mouse? 4. How much time to you have to commit to this project from now on? In particular from now until we think everything is finished, and then later when 2.0 is in beta? My opinions about the answers to these questions are: 1. Yes. It immediately improves the current interface, and it probably makes it easier to add some of the future enhancements that have been talked about. There are some parts that need to be improved further, for example doing the re-ordering using drag and drop, but we can release what we have now, it is good enough, and make further improvements later. On the consensus subject, I will start another thread in the quiz forum in a moment. Annoyingly, Martin D is still on holiday at the Olympics, so I won't be able to discuss this with him until Monday, which is bad timing. 2. I would like to review the code some more. I have mostly been focussing on using the functionality in my recent testing. For the remaining questions, your probably have a better idea than me, hence the fact it would be good to talk.
          Hide
          Tim Hunt added a comment -

          Bit of lunch-time fiddling - an improved essay question icon.

          Show
          Tim Hunt added a comment - Bit of lunch-time fiddling - an improved essay question icon.
          Hide
          Olli Savolainen added a comment -

          The essay icon looks more finished now . There is an implication of a "pretty darn long answers required" to that icon, as well as the name "essay", which may not be what teachers are looking for, though - the need that an essay q can serve may just as well be a question requiring a shorter answer (another small glimpse to the usability test results last week). I don't know what to do about that, though, except renaming the question to "Freeform text/Essay" perhaps. Also I am not sure if the contrast of the grey "text" is enough or could that hypothetically confuse someone. Just wondering .

          Initial thoughts:

          1. The comments about the demo have all been mostly favourable. One thing that really needs to be settled is switching between quiz editing and question bank. More about that in my report, which I hope to publish tomorrow.

          2. I have tried to stick to general PHP coding guidelines and Moodle guidelines. However, I have a bit of an paranoid feeling about having covered all Moodle's guidelines since at the beginning of the summer new docs documentation about development I had not seen, seemed to pop up every once in a while.

          3.
          It is designed to work javascript turned off. Unfortunately the javascript currently seems to have some bugs so there are issues if javascript is turned on, on both IE and Opera. Not sure if it is a YUI issue or a YUI user issue .

          Keyboard usage could probably be improved quite a bit from the current state - adding accesskey properties and setting tabbing order etc.
          >
          The HTML is valid, or very close at least, now that I have moved the styles to <head>. This will not be an issue.

          4. I am writing my master's thesis about this project this next semester, and I believe it will motivate me to have something concrete to do with the subject, as well as analyzing usability work in an open source project. Besides that, I am learning French and building up a new social sphere since I don't know almost anyone from Metz, France yet. During the following two or three week it will probably be pretty crazy trying to arrange everything and settling in, but after that I expect to have lots of time and motivation for this.

          Show
          Olli Savolainen added a comment - The essay icon looks more finished now . There is an implication of a "pretty darn long answers required" to that icon, as well as the name "essay", which may not be what teachers are looking for, though - the need that an essay q can serve may just as well be a question requiring a shorter answer (another small glimpse to the usability test results last week). I don't know what to do about that, though, except renaming the question to "Freeform text/Essay" perhaps. Also I am not sure if the contrast of the grey "text" is enough or could that hypothetically confuse someone. Just wondering . Initial thoughts: 1. The comments about the demo have all been mostly favourable. One thing that really needs to be settled is switching between quiz editing and question bank. More about that in my report, which I hope to publish tomorrow. 2. I have tried to stick to general PHP coding guidelines and Moodle guidelines. However, I have a bit of an paranoid feeling about having covered all Moodle's guidelines since at the beginning of the summer new docs documentation about development I had not seen, seemed to pop up every once in a while. 3. It is designed to work javascript turned off. Unfortunately the javascript currently seems to have some bugs so there are issues if javascript is turned on, on both IE and Opera. Not sure if it is a YUI issue or a YUI user issue . Keyboard usage could probably be improved quite a bit from the current state - adding accesskey properties and setting tabbing order etc. > The HTML is valid, or very close at least, now that I have moved the styles to <head>. This will not be an issue. 4. I am writing my master's thesis about this project this next semester, and I believe it will motivate me to have something concrete to do with the subject, as well as analyzing usability work in an open source project. Besides that, I am learning French and building up a new social sphere since I don't know almost anyone from Metz, France yet. During the following two or three week it will probably be pretty crazy trying to arrange everything and settling in, but after that I expect to have lots of time and motivation for this.
          Hide
          Tim Hunt added a comment -

          By the way, the new interface for adding a random question to the quiz does not work for me. The form appears, but I get an error when I click submit.

          Some comments on the code:

          lang/en_utf8/quiz.php

          • the strings in lang files should be sorted alphabetically, although I understand why you wanted to keep all the new strings separate while this was a patch.
          • I might tweak the wording of some of the English strings, but then it is my native language.

          lang/en_utf8/help/quiz/editconcepts.html

          • Similarly, I would edit the wording slightly.

          lib/weblib.php

          • In popup_form, the line "$submitvalue=$go;" should be outside the inner if statement.
          • The hack in print_header needs to go. Acutally see (and vote for!) MDL-16151, which is something that has been needed for ages.
          • print_paging_bar - are these changes really relevant to the current project? If they are a separate thing, probably better to file a separate tracker bug and patch for these.

          question/type/essay/icon.gif
          question/type/random/icon.gif

          • I like the new icons, particularly the random one.

          question/category_class.php
          question/category_form_randomquestion.php

          • A lot of these changes are related to the quiz UI, although they are also related to random questions. Do they really belong here, or would they be better somewhere in the quiz?

          question/type/edit_question_form.php
          question/question.php
          question/editlib.php

          • No problems. Just listing here so I can track what I have reviewed.

          That is everything outside mod/quiz. Submitting this comment now, before it gets lost. More later.

          Show
          Tim Hunt added a comment - By the way, the new interface for adding a random question to the quiz does not work for me. The form appears, but I get an error when I click submit. Some comments on the code: lang/en_utf8/quiz.php the strings in lang files should be sorted alphabetically, although I understand why you wanted to keep all the new strings separate while this was a patch. I might tweak the wording of some of the English strings, but then it is my native language. lang/en_utf8/help/quiz/editconcepts.html Similarly, I would edit the wording slightly. lib/weblib.php In popup_form, the line "$submitvalue=$go;" should be outside the inner if statement. The hack in print_header needs to go. Acutally see (and vote for!) MDL-16151 , which is something that has been needed for ages. print_paging_bar - are these changes really relevant to the current project? If they are a separate thing, probably better to file a separate tracker bug and patch for these. question/type/essay/icon.gif question/type/random/icon.gif I like the new icons, particularly the random one. question/category_class.php question/category_form_randomquestion.php A lot of these changes are related to the quiz UI, although they are also related to random questions. Do they really belong here, or would they be better somewhere in the quiz? question/type/edit_question_form.php question/question.php question/editlib.php No problems. Just listing here so I can track what I have reviewed. That is everything outside mod/quiz. Submitting this comment now, before it gets lost. More later.
          Hide
          Olli Savolainen added a comment -

          The usual follow-up question: What are you trying to use the random question dialog on?

          print_paging_bar changes are separate I think. They depend on the CSS in the css file of this project, though - making them separate really might be a good idea.

          The random question icon is from the package gnome-tali. I am verifying that it is okay to use an icon from a GPL'd project in another one. http://library.gnome.org/users/gtali/2.21/playing.html.en (that particular icon is not visible in the url but just so you get an idea.

          Show
          Olli Savolainen added a comment - The usual follow-up question: What are you trying to use the random question dialog on? print_paging_bar changes are separate I think. They depend on the CSS in the css file of this project, though - making them separate really might be a good idea. The random question icon is from the package gnome-tali. I am verifying that it is okay to use an icon from a GPL'd project in another one. http://library.gnome.org/users/gtali/2.21/playing.html.en (that particular icon is not visible in the url but just so you get an idea.
          Hide
          Tim Hunt added a comment -

          I am using Firefox 3 on Linux. The console gives a strange error in the middle of a YUI library.

          Forum thread about whether to include this in 2.0: http://moodle.org/mod/forum/discuss.php?d=103869

          Copying from one GPL project to another is fine.

          Another question: Do we need to make any changes to the separate question bank interface? Probably yes, but only small visual changes to the stylesheet, to maintain consistency with the quiz interface.

          Show
          Tim Hunt added a comment - I am using Firefox 3 on Linux. The console gives a strange error in the middle of a YUI library. Forum thread about whether to include this in 2.0: http://moodle.org/mod/forum/discuss.php?d=103869 Copying from one GPL project to another is fine. Another question: Do we need to make any changes to the separate question bank interface? Probably yes, but only small visual changes to the stylesheet, to maintain consistency with the quiz interface.
          Hide
          Olli Savolainen added a comment -

          http://tracker.moodle.org/browse/CONTRIB-643
          It is important to keep the question bank window and the separate question bank as consistent as possible, to avoid confusion. In addition to outlook, element order etc. should be as close as possible. Rather, I would like to think of this as having them only differ where absolutely necessary.

          Also, I am still wondering about whether the question bank window should have a separate "create new category" button. I think it should, but it's a bit tricky to add it anywhere so that it is easy enough to find. And the create new question might be simpler if it were a separate dialog to select the question type from, but then again, it is an additional step.

          Show
          Olli Savolainen added a comment - http://tracker.moodle.org/browse/CONTRIB-643 It is important to keep the question bank window and the separate question bank as consistent as possible, to avoid confusion. In addition to outlook, element order etc. should be as close as possible. Rather, I would like to think of this as having them only differ where absolutely necessary. Also, I am still wondering about whether the question bank window should have a separate "create new category" button. I think it should, but it's a bit tricky to add it anywhere so that it is easy enough to find. And the create new question might be simpler if it were a separate dialog to select the question type from, but then again, it is an additional step.
          Hide
          Tim Hunt added a comment -

          More review comments:

          mod/quiz/addrandom.php

          • Some todos in this file that need to be done. (Yes, you need to log all page views. I know that currently some pages are missed, but this is a bug.)
          • Innapropriate copy-and-pasted comment at the top of this file.
          • You have an unnecessary ?><?php near the end.

          mod/quiz/edit_redesign.css

          • If this code gets released as part of Moodle 2.0, these styles need to be put into theme/standard, with its annoying division of CSS into different files for layout, colours and fonts, and separate files for browser-specific hacks.
          • I note that you have comments in here for things that need to be tested. That would need to be done before 2.0
          • You should normally be able to avoid using !important by using appropriate selectors.
          • You have some empty rules, which should be cleaned up.
          • You have some tabs for indent instead of spaces.

          mod/quiz/edit-js.css

          • instead of using a separate css file like this, I normally do a small script tag that does document.getElementById('repaginatedialog').style.display = 'none';

          mod/quiz/quiz_edit.js

          • Contains commented out code that should probably just be deleted.
          • YAHOO.log("This is a simple log message."); looks like debug code that should be deleted to me.
          • Some lines have trailing whitespace.
          • You have some tabs for indent instead of spaces.

          mod/quiz/tabs.php

          • contains a todo.

          mod/quiz/locallib.php

          • quiz_number_of_pages could be reduced to return substr_count(',' . $layout, ',0');
          • quiz_number_of_questions - it it wise to leave it up to the caller to strip page breaks from the $layout string?
          • quiz_question_preview_button: Do you really want to include an extra space after the img tag when $label is false?

          Some comments on the interface:

          I don't like the blue for the page and question numbers. They make me think that these are links, even though they are in a darker blue than the link colour.

          Reviewing this in 1.9 made me realise that I had only done MDL-14477 in HEAD.

          I am not convinced by the repeated IU elements at the top and bottom of the reordering page. They look silly on very short quizzes, and are not really enough on very long quizzes.

          Is drag-and-drop reordering on the todo list? and have you looked at how re-ording activities on the course front page works? Again, changing that may be something for the future.

          I expect you have already written about this, but why did you keep the add question button in the mini question bank interface? What about combining the display of the current category with with UI for changing category?

          On the quiz settings form, we should change the "Questions per page" caption to "Automatic page breaks" with options "Never", "After every question", "Every 2 questions", ... I don't think we need to give every single option up to 50, either!

          That just leaves the two big files edit.php and editlib.php. More later.

          Show
          Tim Hunt added a comment - More review comments: mod/quiz/addrandom.php Some todos in this file that need to be done. (Yes, you need to log all page views. I know that currently some pages are missed, but this is a bug.) Innapropriate copy-and-pasted comment at the top of this file. You have an unnecessary ?><?php near the end. mod/quiz/edit_redesign.css If this code gets released as part of Moodle 2.0, these styles need to be put into theme/standard, with its annoying division of CSS into different files for layout, colours and fonts, and separate files for browser-specific hacks. I note that you have comments in here for things that need to be tested. That would need to be done before 2.0 You should normally be able to avoid using !important by using appropriate selectors. You have some empty rules, which should be cleaned up. You have some tabs for indent instead of spaces. mod/quiz/edit-js.css instead of using a separate css file like this, I normally do a small script tag that does document.getElementById('repaginatedialog').style.display = 'none'; mod/quiz/quiz_edit.js Contains commented out code that should probably just be deleted. YAHOO.log("This is a simple log message."); looks like debug code that should be deleted to me. Some lines have trailing whitespace. You have some tabs for indent instead of spaces. mod/quiz/tabs.php contains a todo. mod/quiz/locallib.php quiz_number_of_pages could be reduced to return substr_count(',' . $layout, ',0'); quiz_number_of_questions - it it wise to leave it up to the caller to strip page breaks from the $layout string? quiz_question_preview_button: Do you really want to include an extra space after the img tag when $label is false? Some comments on the interface: I don't like the blue for the page and question numbers. They make me think that these are links, even though they are in a darker blue than the link colour. Reviewing this in 1.9 made me realise that I had only done MDL-14477 in HEAD. I am not convinced by the repeated IU elements at the top and bottom of the reordering page. They look silly on very short quizzes, and are not really enough on very long quizzes. Is drag-and-drop reordering on the todo list? and have you looked at how re-ording activities on the course front page works? Again, changing that may be something for the future. I expect you have already written about this, but why did you keep the add question button in the mini question bank interface? What about combining the display of the current category with with UI for changing category? On the quiz settings form, we should change the "Questions per page" caption to "Automatic page breaks" with options "Never", "After every question", "Every 2 questions", ... I don't think we need to give every single option up to 50, either! That just leaves the two big files edit.php and editlib.php. More later.
          Hide
          Olli Savolainen added a comment -

          Great that the tabs are being emphasized further. I hope it is enough. The subtabs suffer this issue, too, actually to a greater degree since at least in the default theme the tabs don't look like tabs at all and they are hard to tell apart if there are multiple words, even if there is generous spacing.

          "I don't like the blue for the page and question numbers. They make me think that these are links, even though they are in a darker blue than the link colour."

          I guess another suitable colour might be found.

          Drag-and-drop is not a priority right now, although yeah I have planned to have it. I have understood that most novice users ignore it on the web anyway so it is an advanced option. http://www.uie.com/brainsparks/2005/11/01/drag-n-drop-is-invisible-to-users/

          More importantly though, is there any reasoning to go against general guidelines and keep the links not underlined? http://www.useit.com/alertbox/20040510.html

          "I expect you have already written about this, but why did you keep the add question button in the mini question bank interface? "

          There is no way to add questions in a random question otherwise?

          "What about combining the display of the current category with with UI for changing category?"

          Testing showed that it is hard to understand what the "box on the right" is actually about. This makes it as clear and fluent to use as possible , takes some hesitation out. For this same reason the title bar of that window was emphasized in the patch you applied. Even though it seems redundant, I don't think it can be taken for granted everybody assumes and trusts that a control for changing the state of the application is also the status display of the same state.

          As the "page breaks" concept is misleading in most cases and foreign to many users (though word processing uses it too, it is not very visible there, either) - compared to just talking about pages - I would vote for keeping consistent and taking "page breaks" out everywhere.

          Show
          Olli Savolainen added a comment - Great that the tabs are being emphasized further. I hope it is enough. The subtabs suffer this issue, too, actually to a greater degree since at least in the default theme the tabs don't look like tabs at all and they are hard to tell apart if there are multiple words, even if there is generous spacing. "I don't like the blue for the page and question numbers. They make me think that these are links, even though they are in a darker blue than the link colour." I guess another suitable colour might be found. Drag-and-drop is not a priority right now, although yeah I have planned to have it. I have understood that most novice users ignore it on the web anyway so it is an advanced option. http://www.uie.com/brainsparks/2005/11/01/drag-n-drop-is-invisible-to-users/ More importantly though, is there any reasoning to go against general guidelines and keep the links not underlined? http://www.useit.com/alertbox/20040510.html "I expect you have already written about this, but why did you keep the add question button in the mini question bank interface? " There is no way to add questions in a random question otherwise? "What about combining the display of the current category with with UI for changing category?" Testing showed that it is hard to understand what the "box on the right" is actually about. This makes it as clear and fluent to use as possible , takes some hesitation out. For this same reason the title bar of that window was emphasized in the patch you applied. Even though it seems redundant, I don't think it can be taken for granted everybody assumes and trusts that a control for changing the state of the application is also the status display of the same state. As the "page breaks" concept is misleading in most cases and foreign to many users (though word processing uses it too, it is not very visible there, either) - compared to just talking about pages - I would vote for keeping consistent and taking "page breaks" out everywhere.
          Hide
          Tim Hunt added a comment -

          OK, so "Automatically start a new page"

          Show
          Tim Hunt added a comment - OK, so "Automatically start a new page"
          Hide
          Matt Gibson added a comment -

          I just had a look at the demo and I like it. +1 for putting this into core as its a lot simpler. I did find the edit quiz screen a bit confusing though - the questions seem to run into one another as did the pages. Same for the order/pages screen - a bit of css to get things away from the left and borders around questions pages to distinguish them would be great.

          Show
          Matt Gibson added a comment - I just had a look at the demo and I like it. +1 for putting this into core as its a lot simpler. I did find the edit quiz screen a bit confusing though - the questions seem to run into one another as did the pages. Same for the order/pages screen - a bit of css to get things away from the left and borders around questions pages to distinguish them would be great.
          Hide
          Matt Gibson added a comment -

          Also, the update this quiz button would be good as another tab. Laia has been discussing this idea elsewhere as part of the usability review and it seems popular.

          Show
          Matt Gibson added a comment - Also, the update this quiz button would be good as another tab. Laia has been discussing this idea elsewhere as part of the usability review and it seems popular.
          Hide
          Olli Savolainen added a comment -

          Thanks Matt, I appreciate it. I agree that the graphical layout of the elements is not as clear as it could be. Vertical margins might help a bit, but adding margin on the left-hand side?

          The update quiz into tab suggestion is linked from here, and I am in favour of it, too.

          (A quick note: I upgraded the demo just now to match the latest patch.)

          Show
          Olli Savolainen added a comment - Thanks Matt, I appreciate it. I agree that the graphical layout of the elements is not as clear as it could be. Vertical margins might help a bit, but adding margin on the left-hand side? The update quiz into tab suggestion is linked from here, and I am in favour of it, too. (A quick note: I upgraded the demo just now to match the latest patch.)
          Hide
          Matt Gibson added a comment -

          Thanks Olli. I was rushing when I looked yesterday and only looked at the first quiz, marked 'demo quiz'. I can see a completely different layout if I go to the 'test pierre pinchet' quiz. (much nicer on edit screen). What's the difference?

          Show
          Matt Gibson added a comment - Thanks Olli. I was rushing when I looked yesterday and only looked at the first quiz, marked 'demo quiz'. I can see a completely different layout if I go to the 'test pierre pinchet' quiz. (much nicer on edit screen). What's the difference?
          Hide
          Olli Savolainen added a comment -

          Oh, right. Sorry about that... it seems that people have made attempts to the quizzes - apparently by changing to student role - and the view of "edit quiz" in that situation is still unfinished, so it currently looks really screwed.

          Show
          Olli Savolainen added a comment - Oh, right. Sorry about that... it seems that people have made attempts to the quizzes - apparently by changing to student role - and the view of "edit quiz" in that situation is still unfinished, so it currently looks really screwed.
          Hide
          Olli Savolainen added a comment -

          Tim, please confirm if the YUI Dialog and its submit button work for you in the new demo now online at http://localhost/moodle/mod/quiz/edit.php?cmid=2 (demo:demo). Also the repaginating dialog should now work in the reorder/paging tab, with also IE6 and Opera9.5 at least.

          Show
          Olli Savolainen added a comment - Tim, please confirm if the YUI Dialog and its submit button work for you in the new demo now online at http://localhost/moodle/mod/quiz/edit.php?cmid=2 (demo:demo). Also the repaginating dialog should now work in the reorder/paging tab, with also IE6 and Opera9.5 at least.
          Hide
          Pierre Pichet added a comment -

          Hi Olli,
          could you attach the last version similar to the test site.
          Thanks

          Show
          Pierre Pichet added a comment - Hi Olli, could you attach the last version similar to the test site. Thanks
          Hide
          Pierre Pichet added a comment -

          I just look at your site and its seems that the version used is 1.9 as said in other comments.
          As we want to put this on 2.0, I think that we should migrate to 2.0 and code in 2.0.
          The complexity of the showbank code ask for modifications so that it can be used in two format if this is the conclusion about this project although I prefer that showbank be as consistent as possible .
          Perhaps some 5.0 features on class can be useful i.e we could create a class for the showbank.
          The code actual definition use terms like question_category_form() although we are a long way from the actual moodleform...

          Show
          Pierre Pichet added a comment - I just look at your site and its seems that the version used is 1.9 as said in other comments. As we want to put this on 2.0, I think that we should migrate to 2.0 and code in 2.0. The complexity of the showbank code ask for modifications so that it can be used in two format if this is the conclusion about this project although I prefer that showbank be as consistent as possible . Perhaps some 5.0 features on class can be useful i.e we could create a class for the showbank. The code actual definition use terms like question_category_form() although we are a long way from the actual moodleform...
          Hide
          Pierre Pichet added a comment -

          Tim,
          A first look at the code shows that to obtain a specific showbank most of the code of question showbank as been reproduced in the mod/quiz/editlib.php.
          Given the complexity of this code including question deletion from the database (not just from the quiz), I think that if we maintain this double showbank feature, the code should be rebuilt so that the functions remain in the same file (question/editlib.php?) with a structure (new class?) that allow the two showbanks to originate from the same main code.

          Show
          Pierre Pichet added a comment - Tim, A first look at the code shows that to obtain a specific showbank most of the code of question showbank as been reproduced in the mod/quiz/editlib.php. Given the complexity of this code including question deletion from the database (not just from the quiz), I think that if we maintain this double showbank feature, the code should be rebuilt so that the functions remain in the same file (question/editlib.php?) with a structure (new class?) that allow the two showbanks to originate from the same main code.
          Hide
          Pierre Pichet added a comment -

          This last remark illustrate the difficulties to code the various valid features of the Olli proposition.
          That is to say that I want to thank Olli for the work done.
          Basically I think that we should continue to develop his project.

          Show
          Pierre Pichet added a comment - This last remark illustrate the difficulties to code the various valid features of the Olli proposition. That is to say that I want to thank Olli for the work done. Basically I think that we should continue to develop his project.
          Hide
          Olli Savolainen added a comment -

          The current version of the project uploaded as patch.Project status: http://docs.moodle.org/en/Development:Quiz_UI_redesign_-_development

          Show
          Olli Savolainen added a comment - The current version of the project uploaded as patch.Project status: http://docs.moodle.org/en/Development:Quiz_UI_redesign_-_development
          Hide
          Pierre Pichet added a comment -

          Thanks Olli

          Show
          Pierre Pichet added a comment - Thanks Olli
          Hide
          Pierre Pichet added a comment -

          However to install it, the files zip is more useful to me.
          If you can set a cvs in the moodel/contrib it will be easier to have the files and all the revisions.

          Show
          Pierre Pichet added a comment - However to install it, the files zip is more useful to me. If you can set a cvs in the moodel/contrib it will be easier to have the files and all the revisions.
          Hide
          Tim Hunt added a comment -

          Thinking about the duplication between question bank drawing code in mod/quiz/editlib.php and question/editlib.php. I think Pierre may be on to something. Perhaps we should change showbank from being a function to being a class. Then question/editlib.php can define a standard implementation, and mod/quiz/editlib.php defines a subclass that changes the bits that need to be changed without duplicating code.

          Or perhaps we should leave that clean-up for now. It is the sort of thing that I could tackle when I am improving the interface for searching the question bank? I'll probably have clearer thought about this when I review the latest patch.

          Show
          Tim Hunt added a comment - Thinking about the duplication between question bank drawing code in mod/quiz/editlib.php and question/editlib.php. I think Pierre may be on to something. Perhaps we should change showbank from being a function to being a class. Then question/editlib.php can define a standard implementation, and mod/quiz/editlib.php defines a subclass that changes the bits that need to be changed without duplicating code. Or perhaps we should leave that clean-up for now. It is the sort of thing that I could tackle when I am improving the interface for searching the question bank? I'll probably have clearer thought about this when I review the latest patch.
          Hide
          Olli Savolainen added a comment -

          I agree that functionality should not be duplicated needlessly. However, I would like to refrain from making architecture-related changes. Also, the changes to the question bank's own UI to keep the UI relatively consistent with Quiz's questio bank UI should be thought through first.

          Show
          Olli Savolainen added a comment - I agree that functionality should not be duplicated needlessly. However, I would like to refrain from making architecture-related changes. Also, the changes to the question bank's own UI to keep the UI relatively consistent with Quiz's questio bank UI should be thought through first.
          Hide
          Pierre Pichet added a comment -

          This project is a multi-task one or multi-objective if you prefer.
          At this time we have not set the final design and this should be done for all the project or step by step.
          The new showbank proposal of Olli is a complete project by itself and a complement ot the creation of the two interfaces i.e. the edit and the order and paging.
          Let first create the two interfaces without doing changes to the question showbank even if there is some double features between the interfaces and the actual showbank.
          When we agree to these two interfaces (the discussion is not finished on the available features of these interfaces) and the necessary code built then we could work on the best showbanks (if we need two different one).

          Show
          Pierre Pichet added a comment - This project is a multi-task one or multi-objective if you prefer. At this time we have not set the final design and this should be done for all the project or step by step. The new showbank proposal of Olli is a complete project by itself and a complement ot the creation of the two interfaces i.e. the edit and the order and paging. Let first create the two interfaces without doing changes to the question showbank even if there is some double features between the interfaces and the actual showbank. When we agree to these two interfaces (the discussion is not finished on the available features of these interfaces) and the necessary code built then we could work on the best showbanks (if we need two different one).
          Hide
          Olli Savolainen added a comment -

          The final design has been very stable ever since the project begun. There have been minor fixes to the original design based on the usability testing that took place in the summer. The changes in the showbank have been usability tested together with the rest of the new UI and results will be unpredictable usability-wise if only the content panes are upgraded.

          In addition, the new user interface of quiz editing/order and paging will probably not work with the old showbank UI as it was, at least due to the difference in dimensions of the new and old showbanks.

          Show
          Olli Savolainen added a comment - The final design has been very stable ever since the project begun. There have been minor fixes to the original design based on the usability testing that took place in the summer. The changes in the showbank have been usability tested together with the rest of the new UI and results will be unpredictable usability-wise if only the content panes are upgraded. In addition, the new user interface of quiz editing/order and paging will probably not work with the old showbank UI as it was, at least due to the difference in dimensions of the new and old showbanks.
          Hide
          Olli Savolainen added a comment -

          Uploading the final patch that appies to moodle1.9-weekly2008-06-30, to apply to Moodle 2.0 HEAD.
          This does not contain the CSS, which will need to be added to Moodle 2.0's theme files after the merge. Naturally also the two changed question type icons have been left out at this point.

          Show
          Olli Savolainen added a comment - Uploading the final patch that appies to moodle1.9-weekly2008-06-30, to apply to Moodle 2.0 HEAD. This does not contain the CSS, which will need to be added to Moodle 2.0's theme files after the merge. Naturally also the two changed question type icons have been left out at this point.
          Hide
          Olli Savolainen added a comment -

          uploaded the separate lang files required by the patch 2008-11-04. To be added to Moodle 2.0 HEAD after merging.

          Show
          Olli Savolainen added a comment - uploaded the separate lang files required by the patch 2008-11-04. To be added to Moodle 2.0 HEAD after merging.
          Hide
          Pierre Pichet added a comment -

          "To be added to Moodle 2.0 HEAD after merging."
          Could you explain your time schedule about putting this on Moodle 2.0?

          Show
          Pierre Pichet added a comment - "To be added to Moodle 2.0 HEAD after merging." Could you explain your time schedule about putting this on Moodle 2.0?
          Hide
          Olli Savolainen added a comment -

          The schedule is ASAP. That is, I am currently creating the patch that would apply to Moodle 2.0 instead of Moodle 1.9. I got most of that patch done today, so I expect the merge to happen within a couple of weeks. I understand from the last discussion with Tim that CVS access is being arranged. Tim, any status updates on this?

          Show
          Olli Savolainen added a comment - The schedule is ASAP. That is, I am currently creating the patch that would apply to Moodle 2.0 instead of Moodle 1.9. I got most of that patch done today, so I expect the merge to happen within a couple of weeks. I understand from the last discussion with Tim that CVS access is being arranged. Tim, any status updates on this?
          Hide
          Pierre Pichet added a comment -

          Should we understand that the version you want to apply to HEAD is the version that we can access on your demo site.

          If yes, I think that Tim should take a look at it, to see if he agrees with the changes done in the interface like having

          a link in question name (Tim proposed to not set the name as a link)
          or the edit icon that disappeared if the name is long or your screen not a large one (i.e. 17 inches)
          or the use icons on the tabs
          or the proposed tab structure which does not allow you to go to the main question bank and back to your quiz edition directly.

          I think that these "details" should be solved before CVS to HEAD.

          Show
          Pierre Pichet added a comment - Should we understand that the version you want to apply to HEAD is the version that we can access on your demo site. If yes, I think that Tim should take a look at it, to see if he agrees with the changes done in the interface like having a link in question name (Tim proposed to not set the name as a link) or the edit icon that disappeared if the name is long or your screen not a large one (i.e. 17 inches) or the use icons on the tabs or the proposed tab structure which does not allow you to go to the main question bank and back to your quiz edition directly. I think that these "details" should be solved before CVS to HEAD.
          Hide
          Tim Hunt added a comment -

          Olli (and Pierre),

          I definitely want to review the code again and test it again before it goes into HEAD. However, once the code is in HEAD, I want Olli to have CVS access so he can work on it directly, without me needing to be in the loop

          I think the steps are these:

          1. Olli makes a patch that applies to HEAD and attached it here.
          2. Olli makes that version available for general testing on his site, and posts in the quiz forum.
          3. I review and test the code (I will make this a priority).
          4. If necessary, I ask Olli to change things in the patch - however I will only do this if necessary. See 6. below.
          5. Olli gets CVS access and the code gets committed.
          6. Ongoing testing and bug fixing. Including fixing most of the issues found in steps 2. and 3. That were not so serious that they had to be fixed before the code went into HEAD.

          Before step 5. I will move this issue into the Moodle project in this tracker, which means that it will gets a new MDL-nnnnn id to use in the commit message.

          All the bugs to be fixed in step 6 should be reported as separate bugs under project Moodle, component Quiz and assigned to Olli. Olli has demonstrated enough commitment to this project that I trust him to do the bug fixing after the merge into head.

          Olli, you might like to review the sub-tasks of this issue and try to mark some of them as resolved.

          Show
          Tim Hunt added a comment - Olli (and Pierre), I definitely want to review the code again and test it again before it goes into HEAD. However, once the code is in HEAD, I want Olli to have CVS access so he can work on it directly, without me needing to be in the loop I think the steps are these: 1. Olli makes a patch that applies to HEAD and attached it here. 2. Olli makes that version available for general testing on his site, and posts in the quiz forum. 3. I review and test the code (I will make this a priority). 4. If necessary, I ask Olli to change things in the patch - however I will only do this if necessary. See 6. below. 5. Olli gets CVS access and the code gets committed. 6. Ongoing testing and bug fixing. Including fixing most of the issues found in steps 2. and 3. That were not so serious that they had to be fixed before the code went into HEAD. Before step 5. I will move this issue into the Moodle project in this tracker, which means that it will gets a new MDL-nnnnn id to use in the commit message. All the bugs to be fixed in step 6 should be reported as separate bugs under project Moodle, component Quiz and assigned to Olli. Olli has demonstrated enough commitment to this project that I trust him to do the bug fixing after the merge into head. Olli, you might like to review the sub-tasks of this issue and try to mark some of them as resolved.
          Hide
          Pierre Pichet added a comment -

          So Olli welcome to the "quiz/question club"

          Show
          Pierre Pichet added a comment - So Olli welcome to the "quiz/question club"
          Hide
          Olli Savolainen added a comment -

          Tim, you mentioned that strings cannot be replaced but a new one must be created. Does this imply that also mistakes can not be corrected?

          Anyway, following that I did this (added the strings with "by") since not repeating "Sort" unnecessarily and taking it as "Sort questions" next to the sorting dropdown element

          • makes both the UI and the list itself more scannable and
          • allows adding a <label> element around the "Sort questions" text

          $string['sortage'] = 'Sort by age';
          $string['sortalpha'] = 'Sort by name';
          $string['sortbyage'] = 'by age';
          $string['sortbyalpha'] = 'by name';
          $string['sortbytypealpha'] = 'by type, name';
          $string['sortquestions'] = 'Sort questions';
          $string['sortsubmit'] = 'Sort questions';
          $string['sorttypealpha'] = 'Sort by type, name';

          The following is not a mistake per se, but the string applies to all situations: the original string 'No questions have been added yet' may be displayed even if the category has already had questions, and would thus be false.

          $string['noquestions'] = 'There are no questions in this category.';

          Also, I alphabetized the strings as follows. However, it seems that en_utf8/quiz.php was not alphabetized in the first place, so my script alphabetized also the old strings. Also, it is kind of hard to see from the diff which strings are really new. Is this ok?

          //check if we are overwriting anything
          $intersections=array_intersect_key($new,$string);
          var_export($intersections);
          echo'<hr>';
          $all=array_merge($string,$new);
          ksort($all,SORT_STRING);
          //we can't do var_export if we want the proper format of moodle lang files:
          foreach($all as $k=>$v)

          { echo "$"."string['$k'] = '".str_replace("'","\'",$v)."';\n"; }

          I will also post the strings in Finnish for the new UI as soon as it is confirmed that the changes are ok in English.

          Show
          Olli Savolainen added a comment - Tim, you mentioned that strings cannot be replaced but a new one must be created. Does this imply that also mistakes can not be corrected? Anyway, following that I did this (added the strings with "by") since not repeating "Sort" unnecessarily and taking it as "Sort questions" next to the sorting dropdown element makes both the UI and the list itself more scannable and allows adding a <label> element around the "Sort questions" text $string ['sortage'] = 'Sort by age'; $string ['sortalpha'] = 'Sort by name'; $string ['sortbyage'] = 'by age'; $string ['sortbyalpha'] = 'by name'; $string ['sortbytypealpha'] = 'by type, name'; $string ['sortquestions'] = 'Sort questions'; $string ['sortsubmit'] = 'Sort questions'; $string ['sorttypealpha'] = 'Sort by type, name'; The following is not a mistake per se, but the string applies to all situations: the original string 'No questions have been added yet' may be displayed even if the category has already had questions, and would thus be false. $string ['noquestions'] = 'There are no questions in this category.'; Also, I alphabetized the strings as follows. However, it seems that en_utf8/quiz.php was not alphabetized in the first place, so my script alphabetized also the old strings. Also, it is kind of hard to see from the diff which strings are really new. Is this ok? //check if we are overwriting anything $intersections=array_intersect_key($new,$string); var_export($intersections); echo'<hr>'; $all=array_merge($string,$new); ksort($all,SORT_STRING); //we can't do var_export if we want the proper format of moodle lang files: foreach($all as $k=>$v) { echo "$"."string['$k'] = '".str_replace("'","\'",$v)."';\n"; } I will also post the strings in Finnish for the new UI as soon as it is confirmed that the changes are ok in English.
          Hide
          Tim Hunt added a comment -

          You've confused me. I cannot tell which of the sort strings are the ones that are currently in Moodle, and which ones are in your code. I'll go and look at your demo...

          You need to stick to the never change lang strings rule. (Except that any string you have added during a development that has not been released yet can be changed during that development.) And remember that the rationale for the rules is to let the translators translate Moodle into all 70+ languages that Moodle supports.

          OK, so the problem with your approach is that you have done:

          Sort questions: [by type, name |v]

          That makes an assumption that is true in English and (I suppose) Finnish, that you have a sentence that can be broken up like that. However that is not universally true. For example Yoda would say "Questions, [by type, name |v], sort" or something.

          The correct way to handle this is to make strings like

          $string['age'] = 'by age';
          $string['questionname'] = 'name';
          $string['qtypename'] = 'type, name';
          $string['sortquestionsbyx'] = 'Sort questions by $a';

          (I called it questionname, rather than assuming you can re-use the 'name' string from moodle.php, because I bet there are languages where idiomatically you use different words for a person's name and the name of an inanimate object). Then do

          $choices = array(get_string('qtypename', 'quiz'), ...);
          $a = choose_from_menu($choices, ... true); // Or should that be popup_form, or whatever the function is called?
          echo get_string('sortquestionsbyx', 'quiz', $a);

          (Then in the Yoda language pack, you can do $string['sortquestionsbyx'] = 'Questions, by $a, sort'; and it works.)

          I know that the quiz is full of lots of old places where language strings are concatenated in ways that make assumptions about word-order, but we should be gradually trying to eliminate them. On the other hand, it is not possible to second-guess every single language out there. Sometimes you just have to make a pragmatic decision, and rely on translators filing bugs if you have done something untranslatable.

          (The thing that is currently giving my big problems is that in the roles system, roles are only defined with singular names, because in some languages, you have lots of agreement rules for different numbers, not just singular an plural, so we can't support everything properly, so they made the decision to just use singular role names. However I am trying to improve the usability of pages like the assign roles page, and I want headings like 'Assign Teachers in course X', however, I can't do that. I have to use "Assign role 'Teacher' in course X" which is not as good in English.)

          Wherever possible, make the lang string key be as close as possible to the English string. So $string['sortbyalpha'] = 'by name'; is bad. If you were going to continue to use that string, you would be better to do $string['byname'] = 'by name';. If not, one day someone will actually want to add the string 'Sort by alpha', and will then by annoyed because the most natural key has already been taken.

          If quiz.php is not currently sorted, then actually it is probably better if we do your big check-in with all the new strings at the end, to make it clear what has changed. Then make a separate commit that just sorts the file. That probably leaves the clearest trace for anyone who later needs to mine CVS history.

          (Unrelated point. I just realised that we can use the Moodle gradebook icon for the 'Results' tab. Now we just an icon for the Info tab. How about the quiz icon there, since that is the closest thing we have to 'Home'.)

          Show
          Tim Hunt added a comment - You've confused me. I cannot tell which of the sort strings are the ones that are currently in Moodle, and which ones are in your code. I'll go and look at your demo... You need to stick to the never change lang strings rule. (Except that any string you have added during a development that has not been released yet can be changed during that development.) And remember that the rationale for the rules is to let the translators translate Moodle into all 70+ languages that Moodle supports. OK, so the problem with your approach is that you have done: Sort questions: [by type, name |v] That makes an assumption that is true in English and (I suppose) Finnish, that you have a sentence that can be broken up like that. However that is not universally true. For example Yoda would say "Questions, [by type, name |v] , sort" or something. The correct way to handle this is to make strings like $string ['age'] = 'by age'; $string ['questionname'] = 'name'; $string ['qtypename'] = 'type, name'; $string ['sortquestionsbyx'] = 'Sort questions by $a'; (I called it questionname, rather than assuming you can re-use the 'name' string from moodle.php, because I bet there are languages where idiomatically you use different words for a person's name and the name of an inanimate object). Then do $choices = array(get_string('qtypename', 'quiz'), ...); $a = choose_from_menu($choices, ... true); // Or should that be popup_form, or whatever the function is called? echo get_string('sortquestionsbyx', 'quiz', $a); (Then in the Yoda language pack, you can do $string ['sortquestionsbyx'] = 'Questions, by $a, sort'; and it works.) I know that the quiz is full of lots of old places where language strings are concatenated in ways that make assumptions about word-order, but we should be gradually trying to eliminate them. On the other hand, it is not possible to second-guess every single language out there. Sometimes you just have to make a pragmatic decision, and rely on translators filing bugs if you have done something untranslatable. (The thing that is currently giving my big problems is that in the roles system, roles are only defined with singular names, because in some languages, you have lots of agreement rules for different numbers, not just singular an plural, so we can't support everything properly, so they made the decision to just use singular role names. However I am trying to improve the usability of pages like the assign roles page, and I want headings like 'Assign Teachers in course X', however, I can't do that. I have to use "Assign role 'Teacher' in course X" which is not as good in English.) Wherever possible, make the lang string key be as close as possible to the English string. So $string ['sortbyalpha'] = 'by name'; is bad. If you were going to continue to use that string, you would be better to do $string ['byname'] = 'by name';. If not, one day someone will actually want to add the string 'Sort by alpha', and will then by annoyed because the most natural key has already been taken. If quiz.php is not currently sorted, then actually it is probably better if we do your big check-in with all the new strings at the end, to make it clear what has changed. Then make a separate commit that just sorts the file. That probably leaves the clearest trace for anyone who later needs to mine CVS history. (Unrelated point. I just realised that we can use the Moodle gradebook icon for the 'Results' tab. Now we just an icon for the Info tab. How about the quiz icon there, since that is the closest thing we have to 'Home'.)
          Hide
          Olli Savolainen added a comment -

          I'll see what the quiz icon will look like. That sounds like a good candidate for home. Then again, using the gradebook icon for results may cause conceptual confusion, since the meanings of the functionalities are not the same but in a sense the quiz results are subordinate to the gradebook.

          The problem then, with the approach you have suggested, is to include the label tag. Shall I just add it to the language string?

          $string['sortquestionsbyx'] = '<label for ="elementname">Sort questions by</label> $a';
          $string['sortquestionsbyx'] = '<label for ="elementname">Questions, </label> $a<label for ="elementname">, sort</label>';

          Patch and demo for Moodle 2.0 coming up on Monday. The migration is quite finished, so I will be moving on to http://docs.moodle.org/en/Development:Quiz_UI_redesign_-_development#After_migration:_when_the_code_is_in_HEAD next week.

          There are two bugs that seem to be caused by other parts of Moodle 2 which we need to go through: Namely, I am not sure how to get the id/context of the default category properly and adding random questions does not currently work, and for some reason adding random questions to a quiz seems to be somehow disabled in also a fresh Moodle 2.0 HEAD.

          Show
          Olli Savolainen added a comment - I'll see what the quiz icon will look like. That sounds like a good candidate for home. Then again, using the gradebook icon for results may cause conceptual confusion, since the meanings of the functionalities are not the same but in a sense the quiz results are subordinate to the gradebook. The problem then, with the approach you have suggested, is to include the label tag. Shall I just add it to the language string? $string ['sortquestionsbyx'] = '<label for ="elementname">Sort questions by</label> $a'; $string ['sortquestionsbyx'] = '<label for ="elementname">Questions, </label> $a<label for ="elementname">, sort</label>'; Patch and demo for Moodle 2.0 coming up on Monday. The migration is quite finished, so I will be moving on to http://docs.moodle.org/en/Development:Quiz_UI_redesign_-_development#After_migration:_when_the_code_is_in_HEAD next week. There are two bugs that seem to be caused by other parts of Moodle 2 which we need to go through: Namely, I am not sure how to get the id/context of the default category properly and adding random questions does not currently work, and for some reason adding random questions to a quiz seems to be somehow disabled in also a fresh Moodle 2.0 HEAD.
          Hide
          Olli Savolainen added a comment - - edited

          To clarify a bit...

          The point about adding the tab icons for preview and edit tabs was that there is a characteristic functionality that is related to exactly these concepts: editing - a quiz or a question - or previewing - a quiz or a single question.

          That is, the broader icon is teaching the meaning of the icons in the narrower sense, too. I do not see any problem in just leaving the other tabs without icons, since they do not really carry any comparable chance to get a novice user to "inadvertedly" learn the usabe of the app. Even though an icon for the info/home tab may not do harm, it is still mostly graphical sugar, though it can perhaps help recognize the tab more fluently, faster.

          Show
          Olli Savolainen added a comment - - edited To clarify a bit... The point about adding the tab icons for preview and edit tabs was that there is a characteristic functionality that is related to exactly these concepts: editing - a quiz or a question - or previewing - a quiz or a single question. That is, the broader icon is teaching the meaning of the icons in the narrower sense, too. I do not see any problem in just leaving the other tabs without icons, since they do not really carry any comparable chance to get a novice user to "inadvertedly" learn the usabe of the app. Even though an icon for the info/home tab may not do harm, it is still mostly graphical sugar, though it can perhaps help recognize the tab more fluently, faster.
          Hide
          Tim Hunt added a comment -

          No worries about the icons, it was just a wild idea late at night.

          In HTML it is allowed for the <label> to completely surround the form control (and in this case, it is supposed to work without needing the for="" attribute, but as usual, IE does not respect that. Therefore, you should be able to do

          echo '<lable for="elementname">, get_string('sortquestionsbyx', 'quiz', $a), '</lable>';

          It is better not to put HTML in lang strings, if you can avoid it.

          Adding a random question works for me. I just tested.

          About the default category. Look at question_edit_setup in question/editlib.php around line 666.

          Show
          Tim Hunt added a comment - No worries about the icons, it was just a wild idea late at night. In HTML it is allowed for the <label> to completely surround the form control (and in this case, it is supposed to work without needing the for="" attribute, but as usual, IE does not respect that. Therefore, you should be able to do echo '<lable for="elementname">, get_string('sortquestionsbyx', 'quiz', $a), '</lable>'; It is better not to put HTML in lang strings, if you can avoid it. Adding a random question works for me. I just tested. About the default category. Look at question_edit_setup in question/editlib.php around line 666.
          Hide
          Olli Savolainen added a comment -

          Here's the patch. It did not apply for styles_color.css (due to http://cvs.moodle.org/moodle/theme/standard/styles_color.css?r1=1.182&r2=1.183) so I removed it from the patch and included that file separately.

          I am sorry to say but the server I run moodle on does not have the php version required by Moodle, so I am afraid I have no place to put the demo with Moodle 2 online. Compiling PHP myself is beyond my range of skills.

          Oh. Thanks. <label> added.

          No, it wasn't a bad wild idea. . Keep 'em coming!

          The below if in category_form_randomquestion.php evaluates true, so in order to make random questions work you have to comment it out.

          if (1 == $DB->count_records_sql("SELECT count
          FROM

          {question_categories} c1,
          {question_categories}

          c2
          WHERE c2.id = ?
          AND c1.contextid = c2.contextid", array($currentcat)))
          $mform->hardFreeze('parent');
          }

          About random questions, that form just doesn't appear for me - at least in the HEAD version I have from a couple of weeks back. It seems in edit.php module_specific_controls() the following evaluates false: if ($maxrand > 0).

          Show
          Olli Savolainen added a comment - Here's the patch. It did not apply for styles_color.css (due to http://cvs.moodle.org/moodle/theme/standard/styles_color.css?r1=1.182&r2=1.183 ) so I removed it from the patch and included that file separately. I am sorry to say but the server I run moodle on does not have the php version required by Moodle, so I am afraid I have no place to put the demo with Moodle 2 online. Compiling PHP myself is beyond my range of skills. Oh. Thanks. <label> added. No, it wasn't a bad wild idea. . Keep 'em coming! The below if in category_form_randomquestion.php evaluates true, so in order to make random questions work you have to comment it out. if (1 == $DB->count_records_sql("SELECT count FROM {question_categories} c1, {question_categories} c2 WHERE c2.id = ? AND c1.contextid = c2.contextid", array($currentcat))) $mform->hardFreeze('parent'); } About random questions, that form just doesn't appear for me - at least in the HEAD version I have from a couple of weeks back. It seems in edit.php module_specific_controls() the following evaluates false: if ($maxrand > 0).
          Hide
          Pierre Pichet added a comment -

          Hi Olli,
          If you put the zip files (not the patch) here I will apply them to my 2.0 site which is PHP5.
          http://132.208.141.198/moodle_head_exp
          you can log as moodle pw:moodle
          If you need, I can also create an admin user with a pasword that I will send you by e-mail.

          Show
          Pierre Pichet added a comment - Hi Olli, If you put the zip files (not the patch) here I will apply them to my 2.0 site which is PHP5. http://132.208.141.198/moodle_head_exp you can log as moodle pw:moodle If you need, I can also create an admin user with a pasword that I will send you by e-mail.
          Hide
          Tim Hunt added a comment -

          Right. I am in the middle of some code today, that I started on Friday, and really want to get it done. So probably I will look at this tomorrow. And I'll answer the technical questions then.

          Show
          Tim Hunt added a comment - Right. I am in the middle of some code today, that I started on Friday, and really want to get it done. So probably I will look at this tomorrow. And I'll answer the technical questions then.
          Hide
          Olli Savolainen added a comment -

          Thank you Pierre, that is great.

          However, I hope to get the couple of migration-borne bugs, discussed above with Tim, ironed out before putting the demo online.

          To clarify further about that other bug about creating random questions: I actually seem to have had getting the default category ok alright, but that default category does not seem to work with the category creating form.

          Show
          Olli Savolainen added a comment - Thank you Pierre, that is great. However, I hope to get the couple of migration-borne bugs, discussed above with Tim, ironed out before putting the demo online. To clarify further about that other bug about creating random questions: I actually seem to have had getting the default category ok alright, but that default category does not seem to work with the category creating form.
          Hide
          Pierre Pichet added a comment -

          Access to question category has to be modified because of permission levels and context definition.
          You should not go higher than the course context.
          In your pipi site I creates pierre random category in the top but as demo I cannot use them.
          However I created pierre random1 at the course level and I can access it.
          This is also the case when you create a question, you cannot create a question anywhere.
          You can move it once created .This is because of question content(files) that could be defined at a context level and will need to be moved to another context through the complex move process

          Show
          Pierre Pichet added a comment - Access to question category has to be modified because of permission levels and context definition. You should not go higher than the course context. In your pipi site I creates pierre random category in the top but as demo I cannot use them. However I created pierre random1 at the course level and I can access it. This is also the case when you create a question, you cannot create a question anywhere. You can move it once created .This is because of question content(files) that could be defined at a context level and will need to be moved to another context through the complex move process
          Hide
          Tim Hunt added a comment -

          I just created MDL-17284 for managing the work remaining to get this into core. I decided that this bug was getting too long and unwieldy.

          I added all watchers and voters for this bug to MDL-17284.

          I am about to start creating subtasks of MDL-17284.

          Show
          Tim Hunt added a comment - I just created MDL-17284 for managing the work remaining to get this into core. I decided that this bug was getting too long and unwieldy. I added all watchers and voters for this bug to MDL-17284 . I am about to start creating subtasks of MDL-17284 .
          Hide
          Olli Savolainen added a comment - - edited

          Pierre, I will put up the files for the current HEAD version zipped in the new MDL-17284 tomorrow.

          Sorry for the delay.

          Show
          Olli Savolainen added a comment - - edited Pierre, I will put up the files for the current HEAD version zipped in the new MDL-17284 tomorrow. Sorry for the delay.
          Hide
          Pierre Pichet added a comment -

          No problem
          As they are already on HEAD, this is not necessary.
          http://132.208.141.198/moodle_head/ is already updated and can be accessed as user:moodle pw: moodle.
          I will try to update on a dayly basis.

          Show
          Pierre Pichet added a comment - No problem As they are already on HEAD, this is not necessary. http://132.208.141.198/moodle_head/ is already updated and can be accessed as user:moodle pw: moodle. I will try to update on a dayly basis.
          Hide
          Tim Hunt added a comment -

          Can we close this bug now? I suppose the only question is, do we need to move any of the subtasks into the MDL project first?

          Show
          Tim Hunt added a comment - Can we close this bug now? I suppose the only question is, do we need to move any of the subtasks into the MDL project first?
          Hide
          Olli Savolainen added a comment -

          Development continues at MDL-17284

          Show
          Olli Savolainen added a comment - Development continues at MDL-17284

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development