Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-5681

Make prechecker to ignore the indentation rules for theme layout files

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.8.5
    • Fix Version/s: None
    • Component/s: Local: Code checker
    • Labels:
      None
    • Affected Branches:
      MOODLE_28_STABLE

      Description

      As raised by Richard Oelmann at https://moodle.org/plugins/view/theme_flexibase the current implementation of the indentation checks fails badly for theme layout files.

      These files are typically HTML files with PHP embedded inline. Normal indentation rules do not fit this situation. Humans readability rules, and should not trigger prechecker error.

      For now, it might be best to simply ignore the indentation check for the theme//layout/ files, as suggested by Eloy Lafuente (stronk7) in the moodle dev chat.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: