Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-5891

Detect and error about C-style comments

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Deferred
    • Affects Version/s: 2.7.9, 2.8.7, 2.9.1
    • Fix Version/s: None
    • Component/s: Local: Code checker
    • Labels:
      None
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE

      Description

      Right now we are not looking for C-style (/* .... */, single or multiline) in the checker. More yet, we are, incorrectly, suggesting them!

      Coding style clearly shows them as incorrect, bad.

      And we have a good number of them:

      $ ag '\/\*$' | wc -l
      3506
      

      Although it's clear they are minority:

      $ ag '\/\**$' | wc -l
      220880
      

      So, this is about to make the checker to detect such incorrect C-style inline comments and report them as errors.

      Ciao

        Attachments

          Activity

            People

            Assignee:
            moodle.com moodle.com
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Participants:
            Component watchers:
            moodle.com, Eloy Lafuente (stronk7)
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: