Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-6003

Eliminate stuff being dependent of $CFG->branch

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.3, 3.0, 3.1
    • Fix Version/s: 3.1
    • Component/s: Module: Survey Pro
    • Labels:
      None
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE

      Description

      It has been detected that, in order to keep the master branch of the module working for all Moodle versions since, say, 2.7. Some conditional code, based on $CFG->branch has been added here and there.

      $ grep -r 'CFG.*branch' *
      lib.php:if ($CFG->branch == '26') {
      mod_form.php:        if ($CFG->branch < '29') {
      settings.php:    if ($CFG->branch < '29') {
      

      That's simply not acceptable and proper branches should be used for every line of code.

      So this is about to:

      1) Decide what goes to the MOODLE_XX_STABLE branches, so people using them can do it up to now.
      2) In master (3.1), kill all the conditional coding above. And its consequences. Completely.
      3) Decide which politic is followed to backport future issues the the MOODLE_XX_STABLES (nothing is backported, everything is backported, only serious bugs are...).

      Ciao

        Attachments

          Activity

            People

            Assignee:
            daniss Daniele Cordella
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Tester:
            Eloy Lafuente (stronk7)
            Participants:
            Component watchers:
            Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              23/May/16