Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-6195

Codechecker whitespace sniffs seem to be off

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 3.1
    • Local: Code checker
    • None
    • 2.5.2
    • MOODLE_31_STABLE

      This may be related to CONTRIB-6146.

      Codechecker seems to be misreporting indenting when scanning plugins. On previous builds of codechecker (2011040400) the utility reported no errors, however the build from (2016031400) is reporting lines that SHOULD NOT be indented as needing to be indented multiple spaces.

      It seems to be misreporting lines that immediately follow lines have been split due to their length.
      Here are some examples from my plugin:

      https://github.com/sbourget/moodle-mod_pcast/blob/master/edit.php#L106
      #106: $episode->mediafile·=·$draftitemid;
      Line indented incorrectly; expected at least 24 spaces, found 0

      https://github.com/sbourget/moodle-mod_pcast/blob/master/edit_form.php#L74
      #74: ········//·Media·File.
      Line indented incorrectly; expected at least 12 spaces, found 8

      Note: Once codechecker misreports one line, it identifies every line in the rest of the file as being incorrectly indented.

            stronk7 Eloy Lafuente (stronk7)
            sbourget Stephen Bourget
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.