Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-6961

Codechecker behat failure

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Inactive
    • Affects Version/s: 3.2, 3.3
    • Fix Version/s: None
    • Component/s: Local: Code checker
    • Labels:
      None
    • Plugin Version:
      2.7.0
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE

      Description

      I am finding three failures in the codechecker behat. I am doing this on a branch from MOODLE_32_STABLE with moodle-local_codechecker 2.7.0 installed as per instructions on the plugins page.

      — Failed steps:

      Then I should see "Well done!" # C:\workspace\m2\local\codechecker\tests\behat\ui.feature:13
      "Well done!" text was not found in the page (Behat\Mink\Exception\ExpectationException)

      Then I should see "Well done!" # C:\workspace\m2\local\codechecker\tests\behat\ui.feature:13
      "Well done!" text was not found in the page (Behat\Mink\Exception\ExpectationException)

      Then I should see "fixtures/phpcompat" # C:\workspace\m2\local\codechecker\tests\behat\ui.feature:37
      "fixtures/phpcompat" text was not found in the page (Behat\Mink\Exception\ExpectationException)

      19 scenarios (16 passed, 3 failed)
      159 steps (150 passed, 3 failed, 6 skipped)
      5m14.44s (43.47Mb)

      The first two failures are easily corrected by changing the line endings of the new local/codechecker folder to unix from windows. (I guess that this might be a consequence of my working on a Windows PC.)

      The last failure is also easily corrected, but requires a code change. Change line 49 of ui.feature from 'fixtures/phpcompat' to 'fixtures\phpcompat' (or even better to just 'phpcompat'). How could this have passed before?

      Also I note that the test takes over 5 mins to run. Most of this time is spent in the 'I log in as "Admin"' and 'I log out'. This test could run much faster by changing the Scenario Outline: to Scenario: and merging the Examples: into the various steps - easily done, and I would be happy to do it.

        Attachments

          Activity

            People

            Assignee:
            jb23347 John Beedell
            Reporter:
            jb23347 John Beedell
            Participants:
            Component watchers:
            moodle.com, Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: