Add-ons
  1. Add-ons
  2. CONTRIB-716

New Project: exabis student review block

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.1
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      works from moodle 1.8 on
    • Database:
      Any
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      22349

      Description

      a plugin für the learn-management-system Moodle which enables teachers to give a verbalized
      judgement and feedback of a student's performance during the year - it is an addition to the usual grades on the report-card.
      This module is very important in use with the eCOOL-concept.

      1. exabis_duplicate.png
        96 kB
      2. klasse.png
        100 kB

        Activity

        Hide
        Anthony Borrow added a comment -

        I noticed the require of the inc.php which strictly speaking does not follow the coding guidelines (http://docs.moodle.org/en/Development:Coding).
        I would encourage you to look in particular at:

        #6 Each file should include (require_once) the main config.php file.
        #7 Any other include/require should use an absolute path beginning with $CFG->dirroot or $CFG->libdir, not relative includes, which sometimes behave strangely under PHP.

        to ensure that your code complies with the coding guidelines. Let me know if you have any questions.

        Peace - Anthony

        Show
        Anthony Borrow added a comment - I noticed the require of the inc.php which strictly speaking does not follow the coding guidelines ( http://docs.moodle.org/en/Development:Coding ). I would encourage you to look in particular at: #6 Each file should include (require_once) the main config.php file. #7 Any other include/require should use an absolute path beginning with $CFG->dirroot or $CFG->libdir, not relative includes, which sometimes behave strangely under PHP. to ensure that your code complies with the coding guidelines. Let me know if you have any questions. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        Also I noticed that on http://localhost/moodle/19stable/blocks/exabis_student_review/configuration_class.php?courseid=2 the word klasse appears in German and I would have expected it to be in English (or the chosen language). I would recommend changing line 10 of the /blocks/exabis_student_review/lib/edit_form.php file to:

        $mform->addElement('text', 'class', get_string('class','block_exabis_student_review').':', array('size' => 50));

        Also a trivial point, I would recommend sorting the language file variables alphabetically. This is not required but I find that when you are looking for whether a string is defined in a particular file having them in alphabetical order is very helpful.

        Peace - Anthony

        Show
        Anthony Borrow added a comment - Also I noticed that on http://localhost/moodle/19stable/blocks/exabis_student_review/configuration_class.php?courseid=2 the word klasse appears in German and I would have expected it to be in English (or the chosen language). I would recommend changing line 10 of the /blocks/exabis_student_review/lib/edit_form.php file to: $mform->addElement('text', 'class', get_string('class','block_exabis_student_review').':', array('size' => 50)); Also a trivial point, I would recommend sorting the language file variables alphabetically. This is not required but I find that when you are looking for whether a string is defined in a particular file having them in alphabetical order is very helpful. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        After creating the first class, I received a PHP notice

        ( ! ) Warning: Invalid argument supplied for foreach() in /home/arborrow/Moodle/code/19stable/blocks/exabis_student_review/configuration.php on line 63

        You may want to run through the block and test things with Debugging set to show all reasonable errors (not developer mode as I find that came make things difficult to work with as it is too strict but all errors gives good feedback).

        Show
        Anthony Borrow added a comment - After creating the first class, I received a PHP notice ( ! ) Warning: Invalid argument supplied for foreach() in /home/arborrow/Moodle/code/19stable/blocks/exabis_student_review/configuration.php on line 63 You may want to run through the block and test things with Debugging set to show all reasonable errors (not developer mode as I find that came make things difficult to work with as it is too strict but all errors gives good feedback).
        Hide
        Anthony Borrow added a comment -

        Also, I noticed that you were using:

        set_config($name, $value);

        it is preferred to make use of config_plugins table by supplying the $plugin variable so it would be like:

        set_config($name, $value, $plugin);

        getting the plugin values can be a little more complicated in some places that way but it will help keep $CFG from becoming bloated. What I did with the MRBS block was to create a separate variable to hold the configuration data for my code. In your case something like:

        $cfg_exabis_student_review or if you want it to be shorter $cfg_esr = get_config($plugin);

        Let me know if you have questions with how to implement this or any specific questions.

        Peace - Anthony

        Show
        Anthony Borrow added a comment - Also, I noticed that you were using: set_config($name, $value); it is preferred to make use of config_plugins table by supplying the $plugin variable so it would be like: set_config($name, $value, $plugin); getting the plugin values can be a little more complicated in some places that way but it will help keep $CFG from becoming bloated. What I did with the MRBS block was to create a separate variable to hold the configuration data for my code. In your case something like: $cfg_exabis_student_review or if you want it to be shorter $cfg_esr = get_config($plugin); Let me know if you have questions with how to implement this or any specific questions. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        Many of these are minor issues and they will serve as a good test of your CVS access. Don't hesitate to let me know if you have any questions. Peace - Anthony

        Show
        Anthony Borrow added a comment - Many of these are minor issues and they will serve as a good test of your CVS access. Don't hesitate to let me know if you have any questions. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        I've bumped your privileges in the tracker so that you can manage the Exabis Student Review block and moved this issue to that component in the tracker. New issues created for that component will automatically be assigned to you. Let me know if you have any questions. Peace - Anthony

        Show
        Anthony Borrow added a comment - I've bumped your privileges in the tracker so that you can manage the Exabis Student Review block and moved this issue to that component in the tracker. New issues created for that component will automatically be assigned to you. Let me know if you have any questions. Peace - Anthony
        Hide
        Anthony Borrow added a comment -

        Components created, privileges bumped, access granted. Did I forget anything? Peace - Anthony

        Show
        Anthony Borrow added a comment - Components created, privileges bumped, access granted. Did I forget anything? Peace - Anthony
        Hide
        Daniel Prieler added a comment -

        Anthony, you are doing a great work!
        Thanks for adding the project and doing code-review.

        Show
        Daniel Prieler added a comment - Anthony, you are doing a great work! Thanks for adding the project and doing code-review.
        Hide
        Anthony Borrow added a comment -

        Closing all of my resolved issues. Peace - Anthony

        Show
        Anthony Borrow added a comment - Closing all of my resolved issues. Peace - Anthony

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development