Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-7505

core unit test failures when oembed_filter installed.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5
    • Fix Version/s: None
    • Component/s: Filter: Oembed
    • Labels:
      None
    • Affected Branches:
      MOODLE_35_STABLE

      Description

      1) core_course_externallib_testcase::test_get_courses_by_field
      Failed asserting that actual size 4 matches expected size 3.

      /var/www/html/course/tests/externallib_test.php:2156
      /var/www/html/lib/phpunit/classes/advanced_testcase.php:80

      This is because the core test checks the number of default filters on the site and the oembed filter is enabled on install in install.php.

      Either - it should not set global state for filter/oembed on install (and require the admin to enable it explicitly) or it could check if the site running unit tests and not set the global state.

        Attachments

          Activity

            People

            Assignee:
            mchurch Mike Churchward
            Reporter:
            danmarsden Dan Marsden
            Participants:
            Component watchers:
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: