-
Bug
-
Resolution: Fixed
-
Minor
-
None
-
3.5.7
-
None
-
2019072700
-
MOODLE_35_STABLE
I found a bug ignoring the global module settings called "block_completion_progress | showinactive". If the settings is ticked that mean show inactive users in report, the module will show only active users.
I found that the code in block/completion_report/overview.php line 200 indicate the following
// ORIGINAL
|
if (get_config('block_completion_progress', 'showinactive') !== 1) { |
extract_suspended_users($context, $userrecords);
|
}
|
the !== means not identical, which is always FALSE, the problem was fixed once I added 1 in a brackets as follow
// FIX
|
if (get_config('block_completion_progress', 'showinactive') !== "1") { |
extract_suspended_users($context, $userrecords);
|
}
|
Can someone confirm if this is a proper FIX? is yes can you push the changes to the module?