Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-7904

block_completion_progress ignoring plugin settings "showinactive"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • 3.5.7
    • None
    • 2019072700
    • MOODLE_35_STABLE

      I found a bug ignoring the global module settings called "block_completion_progress | showinactive". If the settings is ticked that mean show inactive users in report, the module will show only active users.

      I found that the code in block/completion_report/overview.php line 200 indicate the following

      // ORIGINAL
      if (get_config('block_completion_progress', 'showinactive') !== 1) {
          extract_suspended_users($context, $userrecords);
      }
      

      the !== means not identical, which is always FALSE, the problem was fixed once I added 1 in a brackets as follow

      // FIX
      if (get_config('block_completion_progress', 'showinactive') !== "1") {
          extract_suspended_users($context, $userrecords);
      }
      

      Can someone confirm if this is a proper FIX? is yes can you push the changes to the module?

            salvetore Michael de Raadt
            lneoj Jerry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.