Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-8076

Warn about external functions being added out of place

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Deferred
    • Icon: Minor Minor
    • None
    • 3.9
    • Local: Code checker
    • None
    • MOODLE_39_STABLE

      In MDLSITE-6096 it was agreed that se should be creating external functions under component\external[optional_subs]\. 1 external x class x file.

      Of course, like with any coding style change, there isn't any impeding urgency of making the whole codebase to align with that agreement.

      But it's ok to warn developers about the policy above, so this issue is about to add some Sniff able to:

      • Find "incorrect" external uses: basically classes extending external_api not being in the expected location, maybe also by file name (externallib...).
      • Warn about them pointing to the policy in the Docs and recommending to consider the move.

      That's it.

            moodle.com Moodle HQ
            stronk7 Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.