Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-8158

Don't show the closingtime on the Dashboard if it isn't set in the activity instance

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • None
    • 3.8.3, 3.9
    • MOODLE_38_STABLE, MOODLE_39_STABLE

    Description

      Before this patch, the bigbluebuttonbn_print_overview_element() function, which is called from bigbluebuttonbn_print_overview() which is deprecated since Moodle 3.8 but which is still called on previous Moodle core versions and from old-style Moodle Dashboard blocks, didn't check if $bigbluebuttonbn->closingtime is defined in the particular BBB activity instance or not.

      As a result, users saw this line for BBB activity instances with a openingtime set but without a closingtime set.
      Ends: Thursday, 1 January 1970, 1:00 AM

      This patch fixes this flaw in a way that it only shows the closingtime in addition to the openingtime if the closingtime is really set in the BBB activity instance. (PR#249)

      Attachments

        Activity

          People

            jfederico Jesus Federico
            jfederico Jesus Federico
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.