Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-8387

The Certificate manager repository should not have original commits cut off

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10.1
    • Fix Version/s: None
    • Labels:
      None
    • Affected Branches:
      MOODLE_310_STABLE

      Description

      As was raised by Mark Nelson in the developer chat (https://t.me/moodledev/82900) and in the forum (https://moodle.org/mod/forum/discuss.php?d=417684), the Git repository of the Certificate manager started by copying Mark's code (https://github.com/moodleworkplace/moodle-tool_certificate/commit/0acb3f4864df9f1878e954e00e26a4969fc1bfd9) instead of forking it.

      As a result, all the history of Mark's commits was lost so Git commands like git-annotate do not provide right information. Mark is also not mentioned at https://github.com/moodleworkplace/moodle-tool_certificate/graphs/contributors and other places where the commits authorship is used.

      Even though this is not a violation of GNU/GPL (as Mark's copyright statements remained untouched in all files etc), this was not optimal way to start work on top of someone else's project.

      I believe this can be still fixed by rewriting the plugin repository and rebasing it on an appropriate commit in the original Mark's project.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            mudrd8mz David Mudrák (@mudrd8mz)
            Participants:
            Component watchers:
            Emilio Lozano, Marina Glancy, Mikel Martín Corrales
            Votes:
            3 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: