Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-8399

Rewrite settings page

    XMLWordPrintable

Details

    Description

      https://tracker.moodle.org/browse/MDL-70666

      Description

      The settings page includes a number of issues which should be addressed:

      conditional settings are not supported in Moodle. When settings are added condtionally this can lead to missing default values for that setting and later problems as a result
      Renderers should not be used in settings. Things which are not a renderer shoud not be called renderer.
      The use of these functions is counter-intuitive

      Severity

      Medium. Whilst this code does not cause an error, it is highly confusing and unnecessary.
      Proposed solution

      Remove conditional settings for recordings and replace them with disabled settings
      Move the various bigbluebuttonbn_settings_ functions to a new settings class
      Move the renderer functions to this class too
      Call the code in settings.php similar to:

      $manager = new \mod_bigbluebuttonbn\settingsmanager($settings);

      $manager->add_settings();

      Remove all of the validator logic - you must not create settings which are conditional upon the value of other settings

      Difficulty

      Hard. The current code is confusing and will take some unpicking to get right without the use of conditional settings.

      Attachments

        1. image-2021-03-15-14-15-52-869.png
          27 kB
          Jesus Federico
        2. Sélection_999(009).png
          99 kB
          Laurent DAVID
        3. Sélection_999(010).png
          123 kB
          Laurent DAVID
        4. Sélection_999(011).png
          118 kB
          Laurent DAVID

        Issue Links

          Activity

            People

              lmdavid Laurent DAVID
              jfederico Jesus Federico
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.