Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-8400

Inclusion of lib.php has side effects

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.10.1
    • Fix Version/s: None
    • Labels:

      Description

      https://tracker.moodle.org/browse/MDL-70667

      Description

      The lib.php file in the plugin root has a number of side effects. Typically speaking files should not have side effects in this way. We include lib.php from a wide variety of places and it should not cause any change.

      The current lib.php includes a custom configuration file and modifies the global $CFG.
      Severity

      High. Changes of this kind through file inclusion should be avoided.

      b3. Proposed solution
      Migrating existing content of lib.php to more appropriate locations is already covered in MDL-70662. The configuration in this file should be removed and converted to standard configuration settings.

      Rather than hiding credentials and other configuration in this fashion, appropriate admin settings should be used.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jfederico Jesus Federico
              Reporter:
              jfederico Jesus Federico
              Participants:
              Component watchers:
              Jesus Federico
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Time Spent - 1 day, 3 hours, 30 minutes Remaining Estimate - 3 days, 2 hours, 30 minutes
                  3d 2h 30m
                  Logged:
                  Time Spent - 1 day, 3 hours, 30 minutes Remaining Estimate - 3 days, 2 hours, 30 minutes
                  1d 3h 30m