My reasons for re-opening this issue.
1- All moodle developers know that Daniele is a strong advocate of "WC3 strict XHTML compliance". I have already expressed the view that such compliance problems cannot be considered as "bugs" and certainly not "critical" bugs, since they do not prevent Moodle from "normal operation". However I do agree that Moodle should be as compliant as possible... as long as it does not break things.
2- I hope all Moodle developers agree that fixes committed to CVS for stable moodle versions should be considered with care and should not break existing moodle installations. Of course I appreciate that it is very difficult for developers to test bug fixes for all possible existing moodle configurations. It is of course impossible to do such tests for modules, plugins and themes which are not part of moodle regular distribution.
After all these "hedging" considerations here we go...
Here are the problems that I can report with the current fix for Moodle 1.8.
3- If an HTML page ressource is longer than the navigator's viewport , it displays an ugly, confusing and useless double vertical scrollbar (see attached JR01 screenshot). This double scrollbar is displayed with standard themes when in Teacher mode, with Chameleon theme also in Student mode, with CustomCorners themes (in 1.9) in Teacher and Student modes.
4- The new fix breaks the display of my own orangechoc theme (by adding a vertical bar and a horizontal bar etc.) But I have to find a solution for that by myself, of course. (see attached JR02 screenshot).
a) please find a solution to problem explained in #3 as soon as possible
b) in the meantime, please revert to previous "frame display" at least for moodle 1.8
c) re-consider this solution by Jerome Mouneyrac - 23/Sep/08 02:22 PM
change "Keep page navigation visible on the same page" checkbox for a select box with following value:
Yes - With Frame
Yes - No Frame
In conclusion, if there is a way to get rid of the "frame" in resource display in Moodle, I am all for it, but only if it does not cause display problems for embedded resource HTML files.