Moodle
  1. Moodle
  2. MDL-10037

Blog: Site entries display under course entries

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7, 1.7.1, 1.8
    • Fix Version/s: 1.8.3, 1.9
    • Component/s: Blog
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      Site blog entries are displaying when you click the "view course entries" link from the Blog Menu. This occurs regardless of the user's role. It seems the filter type is not working correctly.

        Gliffy Diagrams

        1. edit_form.php
          4 kB
          Matthew Davidson
        2. edit.php
          12 kB
          Matthew Davidson
        3. lib.php
          25 kB
          Matthew Davidson

          Activity

          Hide
          Matthew Davidson added a comment -

          This issue is huge....especially because when you add an entry, it automatically takes you to the site level. After an entry is submitted, the courseid field is not changed in the mdl_post database. Also a user needs the option to publish only to their course. The "course' $filtertype seems to be set correctly, but the lib.php function fetch_entries() doesn't handle it correctly. This should be an URGENT fix because it isn't keeping secure.

          Show
          Matthew Davidson added a comment - This issue is huge....especially because when you add an entry, it automatically takes you to the site level. After an entry is submitted, the courseid field is not changed in the mdl_post database. Also a user needs the option to publish only to their course. The "course' $filtertype seems to be set correctly, but the lib.php function fetch_entries() doesn't handle it correctly. This should be an URGENT fix because it isn't keeping secure.
          Hide
          Matthew Davidson added a comment -

          These three files allow a user to create a course entry. It is not tested allot, and it doesn't fix the main issue of being rerouted to SITE when creating an entry. Maybe a start.

          Show
          Matthew Davidson added a comment - These three files allow a user to create a course entry. It is not tested allot, and it doesn't fix the main issue of being rerouted to SITE when creating an entry. Maybe a start.
          Hide
          Yu Zhang added a comment - - edited

          Hi James and Matthew,

          Blogs are attached to users, and are not course based. The same blog would appear under site/course/group/user blog view. There is a global setting to disable site level blogs, if that is what you are trying to do.

          site blogs - all published blogs of all users on site
          course blogs - all published blogs of all users in course
          group blogs - all published blogs of all users in group
          user blog - all published blogs of this user

          Cheers,

          Yu

          Show
          Yu Zhang added a comment - - edited Hi James and Matthew, Blogs are attached to users, and are not course based. The same blog would appear under site/course/group/user blog view. There is a global setting to disable site level blogs, if that is what you are trying to do. site blogs - all published blogs of all users on site course blogs - all published blogs of all users in course group blogs - all published blogs of all users in group user blog - all published blogs of this user Cheers, Yu
          Hide
          James Ballard added a comment - - edited

          Hi

          Ok, that makes sense.

          Our problem is part of a different issue where global level course creators are appearing as course participants in every course when it seems they should be 'hidden' at this level unless otherwise assigned a role. This causes blog entries by global course creators on any course to appear as course entries on every course even when they have not been assigned course level roles.

          I have just looked into this further and even if you have a hidden assignment role, such users are removed from the participants list but their blog entries still appear as course entries on every course.

          Yours
          James

          Show
          James Ballard added a comment - - edited Hi Ok, that makes sense. Our problem is part of a different issue where global level course creators are appearing as course participants in every course when it seems they should be 'hidden' at this level unless otherwise assigned a role. This causes blog entries by global course creators on any course to appear as course entries on every course even when they have not been assigned course level roles. I have just looked into this further and even if you have a hidden assignment role, such users are removed from the participants list but their blog entries still appear as course entries on every course. Yours James
          Hide
          Yu Zhang added a comment -

          Hi, fixed this in 1.8 and HEAD so that hidden user's blogs are now hidden from users with no capabilities to see hidden users..

          Show
          Yu Zhang added a comment - Hi, fixed this in 1.8 and HEAD so that hidden user's blogs are now hidden from users with no capabilities to see hidden users..

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: