Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-10074

User profile edition uses wrong variable for the (fatal) error message.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8, 1.9
    • Fix Version/s: 1.8.1, 1.9
    • Component/s: Authentication
    • Labels:
      None
    • Database:
      Any
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      When the code in .../user/edit.php (and editadvanced.php) encounters an error trying to update the user details in the external authentication system, it displays an error using the value of $usernew->auth, which sometimes is not defined (e.g., when the user itself is editing his/her own profile). In addtition to that, the code actually tries to update the profile in the authentication system indicated by $user->auth (see line 69 in edit.php, where the call to get_auth_plugin is made()).

      So we should be really using $user->auth for the error message.

      I'm attaching a couple of patches for both 1.8 and 1.9dev, to fix this.

      Saludos. Iñaki.

        Attachments

          Activity

            People

            • Assignee:
              skodak Petr Skoda
              Reporter:
              iarenaza Iñaki Arenaza
              Tester:
              Nobody
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jun/07