Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-10105

grade_item idnumber autogenaration not working for modules

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: None
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE

      Description

      The problem is that the autogeneration code is present only in grade_item->insert(), it should be IMO in grade_item->update() too because the autogenerated one is cleared when updating module settings by the grade_update().

      Another problem is that we should IMO check for uniqueness of idnumber in existing grade_instances and course_modules table.

      Yet another problem might be the use of iteminstance in the autogenerated idnumber; we are sure to encounter duplicates when doing restore - there will have to be uniqueness check too.

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            skodak Petr Skoda
            Tester:
            Nobody Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: