Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-10410

/grade/lib.php typo - use of defined UNCATEGORISED variable vs static, hardcoded string

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 1.8
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      Line 2687 reads:

      $category->name = get_string('uncategorised', 'grades');

      which uses the string 'uncategorised'

      where as lines 2115 and 2390 use the defined variable UNCATEGORISED

      I think we should be consistent and would recommend changing line 2687 to:

      $category->name = get_string(UNCATEGORISED, 'grades'); (this is what Jeff has in GBPv2 but it is different in CVS for 18STABLE.

        Gliffy Diagrams

          Activity

          Hide
          aborrow Anthony Borrow added a comment -

          Fixed to make code more consistent. I suspect Jeff updated this in GBPv2 but just forgot to update it in 18STABLE.

          Show
          aborrow Anthony Borrow added a comment - Fixed to make code more consistent. I suspect Jeff updated this in GBPv2 but just forgot to update it in 18STABLE.
          Hide
          aborrow Anthony Borrow added a comment -

          fixed

          Show
          aborrow Anthony Borrow added a comment - fixed

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                31/Mar/07