Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-10506

Hide/Show Advanced text does not toggle in IE and Safari when edit profile

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8, 1.8.1, 1.8.2, 1.8.3, 1.9
    • Fix Version/s: 1.8.4, 1.9
    • Component/s: Forms Library
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      In IE6 and IE7, the button to hide/show advanced form fields does not toggle its text. Attached is a proposed fix in lib/javascript-static.js file. At the time of writing this, the patch has only been tested with IE6.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            chuang Wen Hao Chuang added a comment -

            Mark do you think you could maybe add a screenshot for this? Thanks!

            Show
            chuang Wen Hao Chuang added a comment - Mark do you think you could maybe add a screenshot for this? Thanks!
            Hide
            chuang Wen Hao Chuang added a comment -

            could someone please clarify where this hide/show "Advanced text" is located please? thanks!

            Show
            chuang Wen Hao Chuang added a comment - could someone please clarify where this hide/show "Advanced text" is located please? thanks!
            Hide
            bushido Mark Nielsen added a comment -

            Edit your user profile in Moodle. In the upper right of the form is a "Show Advanced" button. This is the button that I am referring to and that does not toggle its text when clicked in IE.

            Show
            bushido Mark Nielsen added a comment - Edit your user profile in Moodle. In the upper right of the form is a "Show Advanced" button. This is the button that I am referring to and that does not toggle its text when clicked in IE.
            Hide
            adamann2 Ann Adamcik added a comment -

            The patch seems to work on IE7 as well.

            Show
            adamann2 Ann Adamcik added a comment - The patch seems to work on IE7 as well.
            Hide
            chuang Wen Hao Chuang added a comment - - edited

            We tested this issue and found that it exist not only in IE6 and IE7, but also in Safari on either PC or Mac (that's why I changed the summary of this bug). We tested the patch and it was working fine, so I'm committing the patch into 1.8, 1.9, and head. Thanks! Ticket closed...

            Show
            chuang Wen Hao Chuang added a comment - - edited We tested this issue and found that it exist not only in IE6 and IE7, but also in Safari on either PC or Mac (that's why I changed the summary of this bug). We tested the patch and it was working fine, so I'm committing the patch into 1.8, 1.9, and head. Thanks! Ticket closed...
            Hide
            iverjohnson Iver Johnson added a comment -

            I am using 1.9.3 (Build 20081015) and my users still report the "Advanced" button on the Edit Profile page still doesn't toggle in IE 6 or 7. I have tested this myself, and have found that it doesn't work in IE, but does work fine FF 3.

            This bug is shown as closed, but is it really?

            Show
            iverjohnson Iver Johnson added a comment - I am using 1.9.3 (Build 20081015) and my users still report the "Advanced" button on the Edit Profile page still doesn't toggle in IE 6 or 7. I have tested this myself, and have found that it doesn't work in IE, but does work fine FF 3. This bug is shown as closed, but is it really?
            Hide
            margotsch Margot Schuhmacher added a comment -

            We are having the same issue still in IE 1.9.3+ - the Show Advanced button doesn't work in IE. Bug is closed?

            Show
            margotsch Margot Schuhmacher added a comment - We are having the same issue still in IE 1.9.3+ - the Show Advanced button doesn't work in IE. Bug is closed?

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Jan/08