Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-10533

In forum search results, text is filtered twice, so glossary links don't open in a new window

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 1.9
    • Component/s: Forum
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      I think the problem is this:

      In mod/forum/search.php, around lines 225, it cleans and filters the post. Then on line 254, it calls forum_print_post from mod/forum/lib.php

      That method then calls format_text again around line 2200, shortly after the comment "// Actual content".

      Anyway, I am seeing HTML like

      <a class="glossary autolink glossaryid49" title="public administration" href="http://learnacct.open.ac.uk/mod/glossary/showentry.php?courseid=2371&concept=public+administration" xonclick="return openpopup('/mod/glossary/showentry.php?courseid=2371\&concept=public+administration', 'entry', 'menubar=0,location=0,scrollbars,resizable,width=600,height=450', 0);">public administration</a>

      Note the xonclick=

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Tester:
            Nobody
            Participants:
            Component watchers:
            Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08