Moodle
  1. Moodle
  2. MDL-10883

Remove 3rd party modules langpacks from en_utf8

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.2, 1.8.3, 1.9
    • Fix Version/s: 1.9
    • Component/s: Language
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      28710

      Description

      There are still some files in lang/en_utf8 that belongs to a 3rd party module and, therefore, should be part of the module lang dir, not the core one. This might be a little bit confusing for translators as they should focus on the standard language pack first and then continue with optional 3rd party modules.

      This was already discussed in MDL-4395.

      I have found:

      • attendance.php
      • dialogue.php
      • simpletest.php (???)

        Issue Links

          Activity

          Hide
          Koen Roggemans added a comment -

          journal.php (can this go or not?)
          webquest.php (is this ever been used at all?)

          Show
          Koen Roggemans added a comment - journal.php (can this go or not?) webquest.php (is this ever been used at all?)
          Hide
          Martin Dougiamas added a comment -

          Keep dialogue and journal but all the rest can go

          Show
          Martin Dougiamas added a comment - Keep dialogue and journal but all the rest can go
          Hide
          Koen Roggemans added a comment -

          from the previous bug MDL-4395 about this I also found
          appointment.php: appointment doesn't work in 1.7 and onwards and not in 1.5 and onwards without the mentioned fixes in the forum - think that can go out

          exercise.php:
          I notice that exercise is still in HEAD, although disabled by default. So that should stay

          questionnaire.php: file is extremely outdated - strings should be pulled out the mod/questionnaire/lang folder

          Show
          Koen Roggemans added a comment - from the previous bug MDL-4395 about this I also found appointment.php: appointment doesn't work in 1.7 and onwards and not in 1.5 and onwards without the mentioned fixes in the forum - think that can go out exercise.php: I notice that exercise is still in HEAD, although disabled by default. So that should stay questionnaire.php: file is extremely outdated - strings should be pulled out the mod/questionnaire/lang folder
          Hide
          Nicolas Martignoni added a comment -

          Suggesting re-introduction of simpletest.php, as it is called from these files (at least) :

          • admin/report/simpletest/ex_reporter.php (see line 193)
          • admin/report/simpletest/index.php (see line 25)
          Show
          Nicolas Martignoni added a comment - Suggesting re-introduction of simpletest.php, as it is called from these files (at least) : admin/report/simpletest/ex_reporter.php (see line 193) admin/report/simpletest/index.php (see line 25)
          Hide
          Koen Roggemans added a comment -

          Arch - I checked moodle/grade/simpletest

          I did a cvs update -r 1.2 simpletest.php to get it back in

          Thanks for your head up as ever!

          Show
          Koen Roggemans added a comment - Arch - I checked moodle/grade/simpletest I did a cvs update -r 1.2 simpletest.php to get it back in Thanks for your head up as ever!
          Hide
          Koen Roggemans added a comment -

          This should be it

          Show
          Koen Roggemans added a comment - This should be it
          Hide
          Nicolas Martignoni added a comment -

          Hi Koen,
          The simpletest.php file you committed is empty.

          Show
          Nicolas Martignoni added a comment - Hi Koen, The simpletest.php file you committed is empty.
          Hide
          Koen Roggemans added a comment -

          this is getting ridiculous.
          Should be ok now

          Show
          Koen Roggemans added a comment - this is getting ridiculous. Should be ok now
          Hide
          Nicolas Martignoni added a comment -

          Yes it's OK now
          Closing

          Show
          Nicolas Martignoni added a comment - Yes it's OK now Closing

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: