Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-10969

Invalid XHTML on theme selector page when custom_corners selected: $THEME unset

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      When custom_corners theme is used, viewing the theme selection page produces XHTML warnings about 4 </div> tags missing. These refer to the closing divs for the custom corners theme. The reason is that, at the start of each iteration of the [foreach $theme] loop, the global $THEME is unset to allow for proper displaying of each theme thumbnail preview. At the end of the loop, the global $THEME is set to the last theme in the loop, instead of the original custom_corners.

        Attachments

          Activity

            People

            Assignee:
            nicolasconnault Nicolas Connault
            Reporter:
            nicolasconnault Nicolas Connault
            Tester:
            Nobody
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08