Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-11037

restore status ignored and reset in several places in restore code

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.9
    • Component/s: Backup
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      1/ I made a mistake when fixing MDL-6099 , the result is that the status code of module restores was ignored since 1.6
      2/ the roles restore code resets the $status - we have decided to restore the roles anyway so that teacher have at least some roles in the new course - to be fixed in 2,0
      3/ restore logging code resets the $status too - this is not a critical problem - will be ignored

      After discussion with Eloy we have decided to enable the status check again in 1.9.
      Please note that this might affect some old buggy backups or 3rd party modules with problematic restore code - the symptoms would be that restore does not complete and complains about module restore problems, though previously in 1.8 it did not complain and just ignored the errors...

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            skodak Petr Skoda
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08