Moodle
  1. Moodle
  2. MDL-11090

Password in lesson not visible at settings page

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6, 1.7, 1.7.1, 1.7.2, 1.8, 1.8.1, 1.8.2, 1.9
    • Fix Version/s: 1.9.4, 2.0
    • Component/s: Lesson
    • Labels:
      None
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      28634

      Description

      A password at lesson settings page is not visible if a teacher opens the settings page later again.

      Better solution would be to use a hide/view option and to show that a Password is set by points. Such a function is available for the keyword at course settings page.

        Issue Links

          Activity

          Hide
          Mark Nielsen added a comment -

          Big problem here is that the password is hashed in the database, so it cannot be printed in plain text. This turned out to be a bad idea and I'm not sure how to go about resolving it without breaking previous passwords. Any ideas?

          Show
          Mark Nielsen added a comment - Big problem here is that the password is hashed in the database, so it cannot be printed in plain text. This turned out to be a bad idea and I'm not sure how to go about resolving it without breaking previous passwords. Any ideas?
          Hide
          Howard Miller added a comment -

          Password is now visible in lesson versions newer than today (version 2008112600). Compatibility with the old md5 passwords is retained.

          Show
          Howard Miller added a comment - Password is now visible in lesson versions newer than today (version 2008112600). Compatibility with the old md5 passwords is retained.
          Hide
          Dan Marsden added a comment -

          Hi Howard,

          the version date in HEAD is older than the one in 1.9Stable so this patch breaks upgrades - can you merge these changes into HEAD please?

          thanks!

          Dan

          Show
          Dan Marsden added a comment - Hi Howard, the version date in HEAD is older than the one in 1.9Stable so this patch breaks upgrades - can you merge these changes into HEAD please? thanks! Dan
          Hide
          Dan Marsden added a comment -

          ah - I see you have merged - just missed the version.php file

          Show
          Dan Marsden added a comment - ah - I see you have merged - just missed the version.php file
          Hide
          Petr Škoda added a comment -

          next time please do NOT use date for version in STABLE branch - use just the last two digits

          Show
          Petr Škoda added a comment - next time please do NOT use date for version in STABLE branch - use just the last two digits
          Hide
          Petr Škoda added a comment -

          fixed

          Show
          Petr Škoda added a comment - fixed
          Hide
          Howard Miller added a comment - - edited

          Cool... is that version thing in the developer docs somewhere? I didn't know. Coding guidelines?

          EDIT.... mind you. It's kind of obvious when you think about it for a couple of minutes :-D

          Show
          Howard Miller added a comment - - edited Cool... is that version thing in the developer docs somewhere? I didn't know. Coding guidelines? EDIT.... mind you. It's kind of obvious when you think about it for a couple of minutes :-D
          Hide
          Tim Hunt added a comment -

          Howard, I think you need to trim() the $userpassword in the non-md5 case too.

          Show
          Tim Hunt added a comment - Howard, I think you need to trim() the $userpassword in the non-md5 case too.
          Hide
          Howard Miller added a comment -

          trim added... thanks for spotting that, Tim

          Show
          Howard Miller added a comment - trim added... thanks for spotting that, Tim
          Hide
          Tim Hunt added a comment -

          Thanks Howard.

          Show
          Tim Hunt added a comment - Thanks Howard.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: