Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-11159

block config form needs a name

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9, 2.0
    • Fix Version/s: 1.9, 2.0
    • Component/s: Blocks
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      A new contrib block uses javascript in its config screen. The javascript relies on forms[0] to access to config settings to show an appropriate show/hide icon.

      If you have forms in your theme header, then the block code doesn't work because the config form isn't forms[0].

      To avoid this for this and other blocks, the block config form needs a name attribute "block-config" so that any javascript can be sure to address the right form.

      See http://moodle.org/mod/forum/post.php?reply=348145 for related discussion.

        Attachments

          Activity

            People

            Assignee:
            jenny-gray Jenny Gray
            Reporter:
            jenny-gray Jenny Gray
            Tester:
            Nobody Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08