Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-11192

broken markup due to lang-strings strangles XML-parsing

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Not a bug
    • Affects Version/s: 1.8.2
    • Fix Version/s: 1.9
    • Component/s: General
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      A customer set up moodle an fondled arround with the lang-files (I suppose). "loggedinas" is now set as "You are logged is as:<br>". They obviously tried to spare some space (or what? Have no access to the customers server right now).
      The result is an browsers xml-parser error caused by '<br>' (Chat module).

      We've hacked this and all similar attemtpts to break the system by filtering output to '<br />'

      Is there any way stopping any modules from forcing xml-output?
      Or should some aftercare be implemented to prevent this kind of faliure?

      Users and most admins are clueless about arror output like

      XML-Verarbeitungsfehler: Nicht übereinstimmendes Tag. Erwartet: </br>.
      Adresse: http://moodle-test1/index.php
      Zeile Nr. 83, Spalte 217: <div class="headermenu"><div class="logininfo">Sie sind angemeldet als <br> <a href="/user/view.php?id=2&course=1">Moodle Administrator</a> (<a href="/login/logout.php?sesskey=rlOHYrsyTs">Logout</a>)</div><form action="/course/jumpto.php" method="get" id="chooselang" class="popupform"><div><label for="chooselang_jump"><span class="accesshide">Sprache:</span></label><select id="chooselang_jump" name="jump" onchange="self.location=document.getElementById('chooselang').jump.options[document.getElementById('chooselang').jump.selectedIndex].value;">

      I don't want to start a diskussion about clean markup-issues, I know that bad markup, interperted by bad browsers is an evil thing

      Greetz,

      Christopher

        Attachments

          Activity

            People

            Assignee:
            dougiamas Martin Dougiamas
            Reporter:
            siefer Christoph Siefer
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08