Moodle
  1. Moodle
  2. MDL-11363

merge tables grade_grades with grade_grades_text

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      34839

      Description

      we have discussed today the possibility to merge the tables grade_grades and grade_grades_text

      benefits:

      • maybe faster - potentially less db queries without joins
      • more consistent grades API and coding style - only one class for grades

      problems.

      • solve performance when calculating or recalculating of grades (==regrading) - will file a new bug (new concept of extra/optional properties)

        Activity

        Hide
        Petr Škoda added a comment -

        I will have to fix the sql UPDATE based on final solution in MDL-11347

        Show
        Petr Škoda added a comment - I will have to fix the sql UPDATE based on final solution in MDL-11347
        Hide
        Petr Škoda added a comment -

        adding last version with merged tables and perf improvements (==optional fields)

        Show
        Petr Škoda added a comment - adding last version with merged tables and perf improvements (==optional fields)
        Hide
        Martin Dougiamas added a comment -

        I'm trying it now...

        Show
        Martin Dougiamas added a comment - I'm trying it now...
        Hide
        Petr Škoda added a comment -

        sanding patch against latest cvs (after Eloys context_temp changes)

        Show
        Petr Škoda added a comment - sanding patch against latest cvs (after Eloys context_temp changes)
        Hide
        Martin Dougiamas added a comment -

        Trying it again now (different machine)

        Show
        Martin Dougiamas added a comment - Trying it again now (different machine)
        Hide
        Martin Dougiamas added a comment -

        Gah, CVS is too slow, and I'm falling asleep ...

        The patch was clean, the upgrade was fine, and in my tests around the gradebook and assignment module it all seemed to function well.

        I've not done performance testing but it seems obvious that the one table approach will be faster.

        I think it's OK to check in.

        Show
        Martin Dougiamas added a comment - Gah, CVS is too slow, and I'm falling asleep ... The patch was clean, the upgrade was fine, and in my tests around the gradebook and assignment module it all seemed to function well. I've not done performance testing but it seems obvious that the one table approach will be faster. I think it's OK to check in.
        Hide
        Petr Škoda added a comment -

        committed into CVS, thanks

        Show
        Petr Škoda added a comment - committed into CVS, thanks

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: