Moodle
  1. Moodle
  2. MDL-11385

Fix the XMLDB Editor to avoid some default comments...

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Environment:
      Any
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      28550

      Description

      Avoid default comments for id fields, keys and indexes.

      Clean current ones from install.xml files

      Ciao

        Activity

        Hide
        Eloy Lafuente (stronk7) added a comment -

        They are:

        "id of the table, please edit me"->within new created install.xml files
        "Primary key for XXX"-> within new created install.xml files

        "id of the table, please edit me"> within new created tables>id
        "primary key of the table, please edit me" >within new created tables>pk

        "Default comment for the field, please edit me" when adding a new field
        "Default comment for the index, please edit me" when adding a new index
        "Default comment for the key, please edit me" when adding a new key

        Remove them from the XMLDEditor and from the current install.xml files

        Only the table comment will remain with one: "Default comment for the table, please edit me", because it's interesting to add meaningful comments for the table.

        Show
        Eloy Lafuente (stronk7) added a comment - They are: "id of the table, please edit me"->within new created install.xml files "Primary key for XXX"-> within new created install.xml files "id of the table, please edit me" > within new created tables >id "primary key of the table, please edit me" >within new created tables >pk "Default comment for the field, please edit me" when adding a new field "Default comment for the index, please edit me" when adding a new index "Default comment for the key, please edit me" when adding a new key Remove them from the XMLDEditor and from the current install.xml files Only the table comment will remain with one: "Default comment for the table, please edit me", because it's interesting to add meaningful comments for the table.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        XMLDB Editor fixed. Going to iterate over all install.xml destroying those "default" comments.

        Show
        Eloy Lafuente (stronk7) added a comment - XMLDB Editor fixed. Going to iterate over all install.xml destroying those "default" comments.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Done. Now all the default comments above are out.

        Show
        Eloy Lafuente (stronk7) added a comment - Done. Now all the default comments above are out.

          People

          • Assignee:
            Eloy Lafuente (stronk7)
            Reporter:
            Eloy Lafuente (stronk7)
            Tester:
            Nobody
            Participants:
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: