Moodle
  1. Moodle
  2. MDL-11511

Write entries mod/data:writeentry <-- should not treat adding, editing and deleting all together

    Details

    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      314

      Description

      Write entries mod/data:writeentry <-- this setting let us to set permissions for example to students, to allow them to

      • add
      • edit (own)
      • delete (own)
        entries. These features should be treated separatively, in the sense that there should be three separate setting fields:
      • Add entries mod/data:addentry
      • Edit own entries mod/data:editentry
      • Delete own entries mod/data:deleteentry
      1. mdl-11511.patch
        6 kB
        Dan Poltawski
      2. take2.patch
        6 kB
        Dan Poltawski

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          This patch adds capabilities for doing 'own operations' (edit own entry/delete own entry). Intentionally low-impact.

          The manageentries capability should probably be split down more too.

          Show
          Dan Poltawski added a comment - This patch adds capabilities for doing 'own operations' (edit own entry/delete own entry). Intentionally low-impact. The manageentries capability should probably be split down more too.
          Hide
          Petr Škoda added a comment - - edited

          I like the idea, but did not test the patch: +1
          MD will have to confirm creation of new cap if this goes to 1.9.1...

          Show
          Petr Škoda added a comment - - edited I like the idea, but did not test the patch: +1 MD will have to confirm creation of new cap if this goes to 1.9.1...
          Hide
          Dan Poltawski added a comment -

          Updated to a slightly less ugly patch..

          Show
          Dan Poltawski added a comment - Updated to a slightly less ugly patch..
          Hide
          Dan Poltawski added a comment -

          Grr, actually logic is questionable in second patch if they have manage entries but now edit own entries perm.

          Show
          Dan Poltawski added a comment - Grr, actually logic is questionable in second patch if they have manage entries but now edit own entries perm.
          Hide
          Dongsheng Cai added a comment -

          add 2 new caps in mod/data

          Show
          Dongsheng Cai added a comment - add 2 new caps in mod/data
          Hide
          Martin Dougiamas added a comment -

          Hmm, think about this a bit. Does it really make sense to offer Add without Edit? They would just add another one. Or Edit without Add? or Add without Delete? These kind of complications were all avoided with a single capability.

          Show
          Martin Dougiamas added a comment - Hmm, think about this a bit. Does it really make sense to offer Add without Edit? They would just add another one. Or Edit without Add? or Add without Delete? These kind of complications were all avoided with a single capability.
          Hide
          Martin Dougiamas added a comment -

          Dongsheng please don't commit these things without some review!

          Show
          Martin Dougiamas added a comment - Dongsheng please don't commit these things without some review!
          Hide
          Petr Škoda added a comment -

          Add without Edit - like forum after the edit period (did not study the code yet how that exactly works now)
          They would just add another one. - not if there is max entry limit
          Or Edit without Add? - you could have the add initially, but remove it later
          Add without Delete - I like that

          Show
          Petr Škoda added a comment - Add without Edit - like forum after the edit period (did not study the code yet how that exactly works now) They would just add another one. - not if there is max entry limit Or Edit without Add? - you could have the add initially, but remove it later Add without Delete - I like that
          Hide
          Dan Poltawski added a comment -

          Reason for add without edit was so we could override capabilities and [ab?]use the module as a mechanism for students adding suggestions, then a teacher could approve and edit a field periodically.

          I guess I could see a similar use with the collaborative glossary example:

          • student adds glossary entry
          • teacher cleans it up and approves it
          • student can't edit it again
          Show
          Dan Poltawski added a comment - Reason for add without edit was so we could override capabilities and [ab?] use the module as a mechanism for students adding suggestions, then a teacher could approve and edit a field periodically. I guess I could see a similar use with the collaborative glossary example: student adds glossary entry teacher cleans it up and approves it student can't edit it again
          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this issue.

          We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

          If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

          Michael d.

          TW9vZGxlDQo=

          Show
          Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
          Hide
          Michael de Raadt added a comment -

          I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

          This is being done as part of a bulk annual clean-up of issues.

          If you still believe this is an issue in supported versions, please create a new issue.

          Show
          Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: