Moodle
  1. Moodle
  2. MDL-11728

Strange setting and behaviour in DB ext auth...

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.3, 1.9
    • Fix Version/s: 2.0
    • Component/s: Authentication
    • Labels:
      None
    • Environment:
      Any using ext db auth
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      30083

      Description

      In the ext db auth, in the password setting, these values are available:

      • plain text
      • md5
      • sha1
      • internal

      that "internal" setting is used by the is_internal() method to return true/false.

      And, in moodlelib, if one auth method is internal, then update_user_record() is 100% prevented, so nothing is refreshed from ext db.

      Just guessing if that "internal" value in the db auth plugin has another hidden sense. I cannot find it. Everything gets refreshed properly without it and the ext db, by definition, seems to be a not internal auth plugin.

      I would propose to kill such "internal" option, unless somebody have any explanation for current behaviour (I've take a look to the ldap auth - really similar in concep) and it haven't such "internal" posibility at all.

      So:

      • IMO the db auth plugin should return always false.
      • The plugin should be able to run together with the "cron.php" passwords and "auth_db_sync_users.php " for new users and so on but not using the "internal" concept for that.

      Just one opinion. Ciao

        Activity

        Eloy Lafuente (stronk7) created issue -
        Martin Dougiamas made changes -
        Field Original Value New Value
        Fix Version/s 1.8.5 [ 10252 ]
        Fix Version/s 1.8.4 [ 10242 ]
        Petr Škoda made changes -
        Fix Version/s 1.8.5 [ 10252 ]
        Martin Dougiamas made changes -
        Fix Version/s 1.9.1 [ 10240 ]
        Fix Version/s 1.9 [ 10190 ]
        Martin Dougiamas made changes -
        Fix Version/s 1.9.2 [ 10280 ]
        Fix Version/s 1.9.1 [ 10240 ]
        Petr Škoda made changes -
        Fix Version/s 2.0 [ 10122 ]
        Fix Version/s 1.9.2 [ 10280 ]
        Petr Škoda made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Martin Dougiamas made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        QA Assignee nobody
        Martin Dougiamas made changes -
        Workflow jira [ 22925 ] MDL Workflow [ 57521 ]
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 57521 ] MDL Full Workflow [ 86666 ]

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: