Moodle
  1. Moodle
  2. MDL-1183

insert web link popupscreen too small

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.1
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_12_STABLE
    • Rank:
      10141

      Description

      The insert web link popup screen is too small: the browse and upload butten are not shown. Also the selection buttons are not in a straight line (that could cause the box to be too small)

      Tried this in Dutch/english, standard/custom theme and moodle 1.2 / 1.2.1 dev version.

        Activity

        Hide
        Martin Dougiamas added a comment -

        From Martin Dougiamas (martin at moodle.com) Wednesday, 24 March 2004, 05:09 PM:

        Hmm, looks OK to me. Can you post a screenshot?

        From oen roggemans (koen at roggemans.net) Wednesday, 24 March 2004, 05:33 PM:

        Screenshot uploaded (in dutch, but the English gives the same view) I found it strange nobody mentioned it before, becouse it is in a commonly used function, but I can reproduce it in so many places (different installations, versions, themes, languages, servers) that it worries me.

        From oen roggemans (koen at roggemans.net) Thursday, 25 March 2004, 12:24 AM:

        found! there's a missing </form> -tag on line 249 in moodle\lib\editor\popups\link.php

        From oen roggemans (koen at roggemans.net) Thursday, 25 March 2004, 12:26 AM:

        hmm, bugreport filters out posted html-tags: it's the closing tag of the form, you know how to write that

        From oen roggemans (koen at roggemans.net) Thursday, 25 March 2004, 12:27 AM:

        in link.php from the editor, popupfolder. bugreport filters out the backslashes aswell apparently...

        From oen roggemans (koen at roggemans.net) Thursday, 25 March 2004, 01:02 AM:

        missing slash in /tr on line 258

        delete line 270 (spacer) <div class=space></div>

        and everything fits again

        From Martin Dougiamas (martin at moodle.com) Thursday, 25 March 2004, 01:54 PM:

        Thanks, Koen!

        I've checked in all those fixes for Moodle 1.2.1

        Show
        Martin Dougiamas added a comment - From Martin Dougiamas (martin at moodle.com) Wednesday, 24 March 2004, 05:09 PM: Hmm, looks OK to me. Can you post a screenshot? From oen roggemans (koen at roggemans.net) Wednesday, 24 March 2004, 05:33 PM: Screenshot uploaded (in dutch, but the English gives the same view) I found it strange nobody mentioned it before, becouse it is in a commonly used function, but I can reproduce it in so many places (different installations, versions, themes, languages, servers) that it worries me. From oen roggemans (koen at roggemans.net) Thursday, 25 March 2004, 12:24 AM: found! there's a missing </form> -tag on line 249 in moodle\lib\editor\popups\link.php From oen roggemans (koen at roggemans.net) Thursday, 25 March 2004, 12:26 AM: hmm, bugreport filters out posted html-tags: it's the closing tag of the form, you know how to write that From oen roggemans (koen at roggemans.net) Thursday, 25 March 2004, 12:27 AM: in link.php from the editor, popupfolder. bugreport filters out the backslashes aswell apparently... From oen roggemans (koen at roggemans.net) Thursday, 25 March 2004, 01:02 AM: missing slash in /tr on line 258 delete line 270 (spacer) <div class=space></div> and everything fits again From Martin Dougiamas (martin at moodle.com) Thursday, 25 March 2004, 01:54 PM: Thanks, Koen! I've checked in all those fixes for Moodle 1.2.1
        Hide
        Michael Blake added a comment -

        assign to a valid user

        Show
        Michael Blake added a comment - assign to a valid user

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: