Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-11904

deny/accept Email settings conflict with text

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      The allowemailaddresses / denyemailaddresses check appears to be wrong. The text explaining the allowemailaddresses setting mentions .gov.au as an example. When checked, an @ character is added making @.gov.au which is an invalid address. Plus this makes it impossible to allow for subdomains, so admins would be forced to add every something.gov.au address if they wanted moodle access.

      Currently...

      if (strpos(strrev($email), strrev('@'.$allowedpattern)) === 0) {

      Suggested...

      if (strpos(strrev($email), strrev($allowpattern)) === 0) {

      Or prehaps adding wildcard support would be an idea.

      if ($allowedpattern[0] != '*') {
      $allowedpattern .= '@';
      }
      if (strpos(strrev($email), strrev($allowpattern)) === 0) {

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              daibach David Boyer
              Tester:
              Nobody Nobody
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jan/08