Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-11938

make_categories_list is expensive in the case of large category trees

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9, 2.0
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      make_categories_list is used a lot for simply populating a drop down list of categories in an incredibly expensive recursive fashion (150 database queries for me). Its used all over the shop, and notably on the course edit screen.

      get_categories can get near enough the same data with one query, so should look to change to use this or a new query..

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Mar/08