This should probably not be tagged as "Major". Sorry about that.

To answer your question from Skype:

> Eloy Lafuente: Does Postgres support "backticks" ? Just saw some in the very first lines of
> mod/exercise/lib/postgres.php when reviewing http://tracker.moodle.org/browse/MDL-12023

I've run the following test on Postgres 8.1:

<?php
require_once('config.php');
require_login();
execute_sql(" ALTER TABLE `{$CFG->prefix}exercise_submissions` ADD `late` TINYINT(3) UNSIGNED NOT NULL DEFAULT '0'");
print "\nLast DB error: ".$db->ErrorMsg()."\n";
?>

and got:

Last DB error: ERROR: syntax error at or near "`" LINE 1: ALTER TABLE `mdl_exercise_submissions` ADD `late` TINYINT(3)... ^

Which is likely the reason it had been removed from the branch I am using here at Catalyst.

New versions of these patches which keep the module versions in sync between 1.9 and HEAD

Oki. About patches 1-5 some questions:

1) Why do you take out some rebuild_course_cache() calls? Is that really necessary (I can see the point about not having too much sense to execute them repeatedly if such data isn't needed by the upgrade script itself). Have you left at least one call enabled?

2) In the 18STABLE version.... there is one "extra" change about one create table statement. Why? If has sense, shouldn't it be in all versions?

Will review the next, in some hours... thanks!

Thanks for reviewing these ones Eloy, I wasn't sure exactly about the two things that you pointed out and was hoping to discuss them a bit here

I made these changes in order to be able to go through the upgrade successfully. I don't remember exactly what the errors were but I think it had something to do with role assignments being done without the role tables being there yet.

I will do another test upgrade to see if I can get the exact error message for you.

By the way, I'll commit the postgres DB fixes to exercise, scorm and rqp today once Penny has reviewed them.

Updated patch for mod/scorm on 1.6.

Note that on 1.6 and 1.7, the postgres upgrade script is fine.

Great no problem at all!

Just be careful with version files (I think it's easy to move the versions to the same value because there weren't more changes between them). I've quick-reviewed the DB changes (attachments nº6 and so on) and look correct.

Just have some doubts about the 2 points exposed above (the need to keep at least ONE rebuild_course_cache() call and the create table change).

Anyway, I assign this bug to you... (I'll remain as watcher).

Happy commits with Penny (and don't forget tagging!)

Great work, thanks! Ciao

Get rid of backticks in the Postgres upgrade file

All patches except 1-5 were committed with Penny.

Alright, after doing more tests on this Postgres upgrade from 1.6 to 1.8, it turns out that the only necessary change in those 16_to_18_upgrade patches is the removal of "rebuild_course_cache()" in lib/db/upgrade.php.

How should we fix this?

Adding Tim, ML says it is the bug related to quiz commit you asked about today...

No no no no no Francois you can't make database changes in the stable branches!

http://moodle.cvs.sourceforge.net/moodle/moodle/mod/scorm/db/upgrade.php

Have you done this anywhere else?

My apologies, I over reacted there. Generally you should not, but I agree that in this case it is OK and works fine.

The rebuild_course_cache() errors have been moved to MDL-12160