Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12055

Forum subscribe continues to index page rather than forum page, if no session

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9, 2.0
    • Fix Version/s: 1.9, 2.0
    • Component/s: Forum
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      The forum subscribe page redirects back using the extremely odd forum_go_back_to function, which looks for a return address in the session.

      If there is no return address, such as when clicking the link from an email, the default address is to the forums index.php for the course.

      We (and now other sites presumably, thanks to the general config option) do not use index.php so this is a bit confusing. It is also unnecessary because subscribe.php is guaranteed to have a specific, valid forum ID.

      I think this session behaviour is awful but given that we are near 1.9 release I don't propose changing it. I'm just tweaking it so that it redirects to the forum page instead by default.

        Attachments

          Activity

            People

            • Assignee:
              quen Sam Marshall
              Reporter:
              quen Sam Marshall
              Tester:
              Nobody
              Participants:
              Component watchers:
              Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Mar/08