Moodle
  1. Moodle
  2. MDL-12120

Assign roles role overrides would be better as two separate tabs next to 'update'

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9
    • Component/s: Roles / Access
    • Labels:
      None
    • Rank:
      37053

      Description

      When updating an activity, it would be better to have three tabs at the top rather than have to click twice for role overrides. Especially as its not clear where overrides is without this or that it is available.

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          Good idea ... this would simplify things a lot. Not sure how it will work out code-wise.

          Show
          Martin Dougiamas added a comment - Good idea ... this would simplify things a lot. Not sure how it will work out code-wise.
          Hide
          Martin Dougiamas added a comment -

          I'll have a shot at this one actually

          Show
          Martin Dougiamas added a comment - I'll have a shot at this one actually
          Hide
          Martin Dougiamas added a comment -

          This screenshot shows what I've got working here locally. I want to be sure people are OK with it before I check in.

          This one is for the module editing screen. The same tab names (and lack of second level tabs) appears on all other other role assignment pages too.

          Show
          Martin Dougiamas added a comment - This screenshot shows what I've got working here locally. I want to be sure people are OK with it before I check in. This one is for the module editing screen. The same tab names (and lack of second level tabs) appears on all other other role assignment pages too.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          +1 Looks really simpler!

          Also, I hope the "extratabs" hack will be respected with this change ( http://tracker.moodle.org/browse/MDL-9736 )

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - +1 Looks really simpler! Also, I hope the "extratabs" hack will be respected with this change ( http://tracker.moodle.org/browse/MDL-9736 ) Ciao
          Hide
          John Isner added a comment -

          I think it's an improvement. But don't change terminology "Override" to "Modify permissions" unless you make the change everywhere, including all documentation. Otherwise it will be an endless source of confusion, similar to the confusion that resulted when Inherit changed to Not set. IMO override is already deeply ingrained and should be retained.

          Show
          John Isner added a comment - I think it's an improvement. But don't change terminology "Override" to "Modify permissions" unless you make the change everywhere, including all documentation. Otherwise it will be an endless source of confusion, similar to the confusion that resulted when Inherit changed to Not set. IMO override is already deeply ingrained and should be retained.
          Hide
          Martin Dougiamas added a comment -

          Yes, I was worrying about that too, but on the other hand the new string seems a lot better for newbies. Since the content under the tabs is the same I was assuming people used to 1.8 would understand the switch pretty quickly. Thoughts?

          Otherwise: "Override permissions" ?

          Show
          Martin Dougiamas added a comment - Yes, I was worrying about that too, but on the other hand the new string seems a lot better for newbies. Since the content under the tabs is the same I was assuming people used to 1.8 would understand the switch pretty quickly. Thoughts? Otherwise: "Override permissions" ?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Perhaps we could perform that in 2 steps:

          • "Override permissions" for 1.9. It's better for newbies and understandable for traditional users.
          • "Change permissions" for 2.0. Easy for both collectives too. IMO.

          Noting such changes in sensible places, of course (Docs, help files, forums...)

          +1 for that.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Perhaps we could perform that in 2 steps: "Override permissions" for 1.9. It's better for newbies and understandable for traditional users. "Change permissions" for 2.0. Easy for both collectives too. IMO. Noting such changes in sensible places, of course (Docs, help files, forums...) +1 for that. Ciao
          Hide
          Martin Dougiamas added a comment -

          OK, I've checked in these changes (with "Override permissions"). I think it's a good step forward. There are still lots more we can do I'm sure.

          Show
          Martin Dougiamas added a comment - OK, I've checked in these changes (with "Override permissions"). I think it's a good step forward. There are still lots more we can do I'm sure.
          Hide
          Helen Foster added a comment -

          Override roles documentation page renamed as Override permissions, with new screenshot and note about page renaming.

          http://docs.moodle.org/en/Override_permissions

          Show
          Helen Foster added a comment - Override roles documentation page renamed as Override permissions, with new screenshot and note about page renaming. http://docs.moodle.org/en/Override_permissions

            People

            • Votes:
              5 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: