Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12161

Slashes not stripped on SCORM tree list

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.3
    • Fix Version/s: 1.9.3
    • Component/s: SCORM
    • Labels:
      None
    • Environment:
      ALL
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      If SCO title contains special characters (', ", ...) slashes are not stripped.
      see SCORM-TREE.jpg

      I popose a solution adding the following line

      $sco->title = stripslashes($sco->title);

      on

      mod/scorm/datamodels/scorm_13lib.php line 66

      and

      mod/scorm/datamodels/scorm_12lib.php line 216

        Gliffy Diagrams

        1. SCORM-TREE.jpg
          33 kB

          Activity

          Hide
          upo Roberto Pinna added a comment -

          Hi Marco,
          can you attach a test package.

          Grazie,
          Roberto

          Show
          upo Roberto Pinna added a comment - Hi Marco, can you attach a test package. Grazie, Roberto
          Hide
          marco.loche Marco Loche added a comment - - edited

          Hi Roberto

          The lo.zip file attached over is a SCORM 1.2 package with some special characters on title.

          <title>SCO - Test special char - ' "</title>

          Without the patch proposed the title on TOC looks like :

          SCO - Test special char - \' \"

          with the patch slashes are stripped

          Prego

          Marco

          Show
          marco.loche Marco Loche added a comment - - edited Hi Roberto The lo.zip file attached over is a SCORM 1.2 package with some special characters on title. <title>SCO - Test special char - ' "</title> Without the patch proposed the title on TOC looks like : SCO - Test special char - \' \" with the patch slashes are stripped Prego Marco
          Hide
          danmarsden Dan Marsden added a comment -

          this was fixed as part of MDL-8193

          thanks,

          Dan

          Show
          danmarsden Dan Marsden added a comment - this was fixed as part of MDL-8193 thanks, Dan

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Oct/08