Moodle
  1. Moodle
  2. MDL-12212

Reimplement $PAGE for Navigation 2.0

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 2.0
    • Component/s: Blocks, Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The implementation of blocks is completely rotten, rife with inconsistencies and gaps.

      This meta bug is to track the complete review and overhaul of blocks to make them something we can be proud of.

      One objective is to not break compatibility for the blocks themselves - this is just about pagelib, really and making it work consistently and simply across all the pages in Moodle.

        Gliffy Diagrams

          Issue Links

            Activity

            Martin Dougiamas created issue -
            Hide
            Martin Dougiamas added a comment -

            Just 2.0

            Show
            Martin Dougiamas added a comment - Just 2.0
            Martin Dougiamas made changes -
            Field Original Value New Value
            Fix Version/s 1.9.1 [ 10240 ]
            Hide
            Martin Dougiamas added a comment -

            Most important thing on the new implementation is to base it around contexts instead of pageids

            Show
            Martin Dougiamas added a comment - Most important thing on the new implementation is to base it around contexts instead of pageids
            Martin Dougiamas made changes -
            Summary META: Complete review and consolidation of pagelib and the implementation of blocks throughout Moodle META: Complete review and rewrite of Pagelib (and blocks)
            Hide
            Dan Poltawski added a comment -

            Just so I remember to document this:

            I was playing around trying to make a fancy block this weekend with YUI popups (much like the the repository picker). (I haven't researched very far, so could be wrong). But I don't think its currently possible to generate the necessarily html snippets in with the block to do this. (And I think to include the js we would need to d it on anything which includes the block - I don't think there is a way to include stuff in the head of html)

            Show
            Dan Poltawski added a comment - Just so I remember to document this: I was playing around trying to make a fancy block this weekend with YUI popups (much like the the repository picker). (I haven't researched very far, so could be wrong). But I don't think its currently possible to generate the necessarily html snippets in with the block to do this. (And I think to include the js we would need to d it on anything which includes the block - I don't think there is a way to include stuff in the head of html)
            Hide
            Tim Hunt added a comment -

            I seem to be using http://docs.moodle.org/en/Development:Navigation_2.0_implementation_plan instead of meta-bugs, so poaching this bug to use for $PAGE implementation.

            $PAGE seems to be referred to in 190 places in 31 files. Lets see how much of that I can keep backwards-compatible.

            Show
            Tim Hunt added a comment - I seem to be using http://docs.moodle.org/en/Development:Navigation_2.0_implementation_plan instead of meta-bugs, so poaching this bug to use for $PAGE implementation. $PAGE seems to be referred to in 190 places in 31 files. Lets see how much of that I can keep backwards-compatible.
            Tim Hunt made changes -
            Summary META: Complete review and rewrite of Pagelib (and blocks) Reimplement $PAGE for Navigation 2.0
            Assignee Martin Dougiamas [ dougiamas ] Tim Hunt [ timhunt ]
            Hide
            Tim Hunt added a comment -

            Work in progress - I just wanted an off-site backup. However, if anyone wants to review it and comment on the direction I am taking, please be my guest.

            Show
            Tim Hunt added a comment - Work in progress - I just wanted an off-site backup. However, if anyone wants to review it and comment on the direction I am taking, please be my guest.
            Tim Hunt made changes -
            Attachment patchseries.txt [ 16933 ]
            Hide
            Tim Hunt added a comment -

            Updated patch series, should anyone care.

            Show
            Tim Hunt added a comment - Updated patch series, should anyone care.
            Tim Hunt made changes -
            Attachment patchseries.txt [ 17005 ]
            Hide
            Tim Hunt added a comment -

            Updated patch series for Nico.

            Show
            Tim Hunt added a comment - Updated patch series for Nico.
            Tim Hunt made changes -
            Attachment patchseries.txt [ 17029 ]
            Hide
            Martin Dougiamas added a comment -

            I care, Tim. Thanks for pushing on with this so well.

            Show
            Martin Dougiamas added a comment - I care, Tim. Thanks for pushing on with this so well.
            Hide
            Tim Hunt added a comment -

            I should add, the current version prints a lot of developer debug warnings, becuase I have not finished updating legacy code.

            Show
            Tim Hunt added a comment - I should add, the current version prints a lot of developer debug warnings, becuase I have not finished updating legacy code.
            Hide
            Tim Hunt added a comment -

            Update work in progress.

            Show
            Tim Hunt added a comment - Update work in progress.
            Tim Hunt made changes -
            Attachment patchseries.txt [ 17089 ]
            Tim Hunt made changes -
            Attachment patchseries.txt [ 17102 ]
            Tim Hunt made changes -
            Attachment patchseries.txt [ 17089 ]
            Tim Hunt made changes -
            Attachment patchseries.txt [ 17029 ]
            Tim Hunt made changes -
            Attachment patchseries.txt [ 17005 ]
            Tim Hunt made changes -
            Attachment patchseries.txt [ 16933 ]
            Hide
            Tim Hunt added a comment -

            This is now in CVS. There are a few odds and ends that need to be cleaned finished, but that will be done as parts of other issues. I am closing this bug now for the pleasing sense of closure it gives me

            Show
            Tim Hunt added a comment - This is now in CVS. There are a few odds and ends that need to be cleaned finished, but that will be done as parts of other issues. I am closing this bug now for the pleasing sense of closure it gives me
            Tim Hunt made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Dan Poltawski made changes -
            Link This issue will help resolve MDL-4138 [ MDL-4138 ]
            Martin Dougiamas made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            QA Assignee nobody
            Martin Dougiamas made changes -
            Workflow jira [ 23445 ] MDL Workflow [ 57885 ]
            Martin Dougiamas made changes -
            Workflow MDL Workflow [ 57885 ] MDL Full Workflow [ 87031 ]

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: