Details
Bug
Closed
Major
Description
Add custom corner divs to boxes on Moodle pages.
Create wrapper functions to add the necessary divs within boxes.
Issue Links
Activity
The admin/lang.php?mode=missing shows an interesting page structure. Please check the screenshot http://screencast.com/t/AhxuZTfCULp.
I am not sure any more if it is wise to replace all boxes with the same custom_corners supporting function. Developers use boxes not only for content containers. Content containers should have custom_corners support. Any other boxes (to collect some elements or whatever) should be built without custom_corners support.
A bit more semantic code would help out IMO. May be we need a semantic option to specify the content type of the box: "layout", "wrapper", "text" for example. And wrapper boxes don't write the custom_corners divs. We may need to analyze the box usage a bit more.
Custom_corners looks like a never ending story 
basic containers backported into 1.8.x, themes from 1.9 work again in latest 1.8.x
The wrapper functions are:
/**
*
*/
function print_custom_corners_box($message, $classes='generalbox', $ids='', $return=false) {
$output = print_custom_corners_box_start($classes, $ids, true);
$output .= stripslashes_safe($message);
$output .= print_custom_corners_box_end(true);
if ($return)
{ return $output; } else { echo $output; }}
/**
* Function adds custom_corners to boxes
* Calls print_box_start
*
* @param string $classes, space-separated class names.
* @param string $ids, space-separated id names.
* @param boolean $return, return as string or just print it
*/
function print_custom_corners_box_start($classes='generalbox', $ids='', $return=false) {
global $CFG, $THEME;
$output = print_box_start('ccbox '.$classes, $ids, true);
if (!empty($THEME->customcorners)) { require_once($CFG->dirroot.'/lib/custom_corners_lib.php'); $output .= print_custom_corners_start(true, true); }
if ($return) { return $output; }
else
{ echo $output; }}
/**
* Function adds custom_corners to boxes
* Calls print_box_end
*
* @param boolean $return, return as string or just print it
*/
function print_custom_corners_box_end($return=false) {
global $CFG, $THEME;
if (!empty($THEME->customcorners)) { require_once($CFG->dirroot.'/lib/custom_corners_lib.php'); $output .= print_custom_corners_end(true); }
$output .= print_box_end(true);;
if ($return) { return $output; } else { echo $output; }
}