Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12264

course/info.php displays course information for hidden courses

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 1.8.3, 1.9
          • Fix Version/s: 1.8.4, 1.9, 2.0
          • Component/s: Course
          • Labels:
            None
          • Affected Branches:
            MOODLE_18_STABLE, MOODLE_19_STABLE
          • Fixed Branches:
            MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

            Description

            The course info page exposes information about the course when either the course or the course category is hidden.

              Gliffy Diagrams

                Attachments

                  Issue Links

                  is blocked by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-13117 http://moodle.org/course/index.php = Click the "i" and see "This course is currently unavailable ..."

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    dolfa Petr Kalis added a comment -

                    Attached patch for 1.9. It takes into account $CFG->allowvisiblecoursesinhiddencategories setting.
                    Still not sure, what for this file is. And its functionality (desired) in case of Guests access. If it is meant to not show course info for guest for courses not allowing guest's access, it is not working too. Is that a bug? Feature?

                    Show
                    dolfa Petr Kalis added a comment - Attached patch for 1.9. It takes into account $CFG->allowvisiblecoursesinhiddencategories setting. Still not sure, what for this file is. And its functionality (desired) in case of Guests access. If it is meant to not show course info for guest for courses not allowing guest's access, it is not working too. Is that a bug? Feature?
                    Hide
                    Permalink
                    matt.clarkson Matt Clarkson added a comment -

                    Thanks for the patch Petr, I have committed it to CVS

                    Show
                    matt.clarkson Matt Clarkson added a comment - Thanks for the patch Petr, I have committed it to CVS
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    Hi, just a note to say the allowvisiblecourseinhiddencategories logic was wrong.

                    course_parent_visible() always returns true if $CFG->allowvisiblecoursesinhiddencategories
                    is true. Which meant you were hiding visible course info from people without moodle/course:viewhiddencourses always - see MDL-13117

                    Show
                    poltawski Dan Poltawski added a comment - Hi, just a note to say the allowvisiblecourseinhiddencategories logic was wrong. course_parent_visible() always returns true if $CFG->allowvisiblecoursesinhiddencategories is true. Which meant you were hiding visible course info from people without moodle/course:viewhiddencourses always - see MDL-13117

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        2 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          11/Jan/08