Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12302

Issue with filter_save_ignore_tags missing empty html tags i.e. <a name="something"></a>

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.9.2
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      In some of our HTML content we have anchor links, unfortunately the regex that is built in filter_save_ignore_tags seems to have issues with empty tags.

      I believe this is because inside the tags it's doing (.+?) - Now I'm not a regex expert, actually far from it, but as far as I can tell that requires at least one char in between the open and closing tags.

      I've fixed this by changing (.+?) to (.*?) which seems to work in all cases.

      Could someone look over this fix, and if it's correct commit it to core.

      Thanks,

      James Brisland

        Attachments

          Activity

            People

            Assignee:
            jenny-gray Jenny Gray
            Reporter:
            mrbriz James Brisland
            Tester:
            Dongsheng Cai
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Jul/08