Moodle
  1. Moodle
  2. MDL-12323

LDAP tries to update external when set not to.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7.3, 1.8.3, 1.9
    • Fix Version/s: 1.7.3, 1.8.3, 1.9
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      29861

      Description

      Just found a duplicate on my system of a user and tried to alter the firstname of the unused one so I could identify and remove it. I got the error

      Could not update external LDAP, check your server logs (or similar).

      Server error logs say nothing. Does it mean the LDAP server logs?

      1. ldap-update-user-profile-19beta2.diff
        2 kB
        Iñaki Arenaza
      1. patch.JPG
        158 kB

        Issue Links

          Activity

          Hide
          Matt Gibson added a comment -

          XAMPP, win2k3 BTW

          Show
          Matt Gibson added a comment - XAMPP, win2k3 BTW
          Hide
          Iñaki Arenaza added a comment -

          Hi Matt,

          could you try the attached patch? I think this should fix this issue, and provide better logging for the more general case of 'Could not update external LDAP' (which should help diagnose the real origin of the problem).

          Saludos. Iñaki.

          Show
          Iñaki Arenaza added a comment - Hi Matt, could you try the attached patch? I think this should fix this issue, and provide better logging for the more general case of 'Could not update external LDAP' (which should help diagnose the real origin of the problem). Saludos. Iñaki.
          Hide
          Iñaki Arenaza added a comment -

          Hi Matt,

          have you had a chance to test the patch?

          Saludos. Iñaki.

          Show
          Iñaki Arenaza added a comment - Hi Matt, have you had a chance to test the patch? Saludos. Iñaki.
          Hide
          Matt Gibson added a comment -

          I've been driving myself nuts trying to get a patch applied on a windows box GNUwin says its garbage.

          Still trying

          Show
          Matt Gibson added a comment - I've been driving myself nuts trying to get a patch applied on a windows box GNUwin says its garbage. Still trying
          Hide
          Matt Gibson added a comment -

          Tried everything. There must be another way.

          Show
          Matt Gibson added a comment - Tried everything. There must be another way.
          Hide
          Iñaki Arenaza added a comment -

          Hi Matt,

          it seems your version of patch is choking on the Unix line fomat of the patch file. You can overcome this by opening the file in Wordpad, then saving is as 'Text document - MSDOS format'.

          If this doesn't fix it, then send me an email at iarenuno_at_eteo_dot_mondragon_dot_edu with your ldap/auth.php file, and I'll send you back the file fully patched for you to test it.

          Saludos. Iñaki.

          Show
          Iñaki Arenaza added a comment - Hi Matt, it seems your version of patch is choking on the Unix line fomat of the patch file. You can overcome this by opening the file in Wordpad, then saving is as 'Text document - MSDOS format'. If this doesn't fix it, then send me an email at iarenuno_at_eteo_dot_mondragon_dot_edu with your ldap/auth.php file, and I'll send you back the file fully patched for you to test it. Saludos. Iñaki.
          Hide
          Matt Gibson added a comment -

          Got it. seems to be fine now.

          Show
          Matt Gibson added a comment - Got it. seems to be fine now.
          Hide
          Iñaki Arenaza added a comment -

          Matt,

          did the patch fixed the real issue?

          Saludos. Iñaki.

          Show
          Iñaki Arenaza added a comment - Matt, did the patch fixed the real issue? Saludos. Iñaki.
          Hide
          Matt Gibson added a comment -

          Not sure what the 'real issue' was, but the thing I was trying to do i.e. deleting the duplicate user account, was not a problem after applying the patch.

          Thanks for making the patch BTW, much appreciated.

          Show
          Matt Gibson added a comment - Not sure what the 'real issue' was, but the thing I was trying to do i.e. deleting the duplicate user account, was not a problem after applying the patch. Thanks for making the patch BTW, much appreciated.
          Hide
          Iñaki Arenaza added a comment -

          Closing now. Thanks for the report and testing!

          Saludos. Iñaki.

          Show
          Iñaki Arenaza added a comment - Closing now. Thanks for the report and testing! Saludos. Iñaki.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: