Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12339

Small improvement to custom corner themes...

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9, 2.0
    • Fix Version/s: 1.9, 2.0
    • Component/s: General, Libraries, Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      After viewing the move to "containers" for custom corners themes, I've tried to rework the contrib wood_custom_corners theme to use the new containers.

      And I've found that, in some situations, where the number of "containers" in a page is high, it's really difficult to point to CSS selectors properly, because nothing differences one container within another container within another container.... from his parent (or at least if forces to write really LONG CSS selectors to match the desired container.

      So I've thought about to add one new "wraplevelXX" (XX = level or depth of the container) class to each container, in order to be able to select them easily with CSS.

      I think it isn't dangerous (nor heavy) at all because only adds one new class to each container in a page. And it really provides high control about what to do with each container level.

      Patch attached. +1 to add this. It can help future custom corner themes for sure (at least the woody one will be benefited).

      Ciao

        Attachments

          Activity

            People

            Assignee:
            stronk7 Eloy Lafuente (stronk7)
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08