Moodle
  1. Moodle
  2. MDL-12407

/userpix/index.php produces invalid XHTML syntax

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.3, 1.9
    • Fix Version/s: 1.8.3, 1.9
    • Component/s: Other
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      29827

      Description

      When browsing http://moodle.site/userpix/index.php on a 1.8.3.+ install, I get the following error with Firefox 2.0.11 on Linux:

      XML Parsing Error: not well-formed
      Location: http://localhost/moodle-18/userpix/index.php
      Line Number 100, Column 69:<a href="http://localhost/moodle-18/user/view.php?id=2&course=1"title="Admin User"><img src="http://localhost/moodle-18/user/pix.php/2/f1.jpg" style="border:0px; width:100px; height:100px" alt="Admin User" /></a>

      The error is due to a missing whitespace between the trailing " character of the 'a' tag and the beginning of the 'title' tag. The same problem is present in 1.9beta2, although Firefox show no XML parsing error unless you set Administration >> Server >> Debugging >> XML Strict Headers.

      The attached patches fix the issue for 1.8.3+ and 1.9beta2.

      Saludos. Iñaki.

      1. userpix-183.diff
        0.6 kB
        Iñaki Arenaza
      2. userpix-19beta2.diff
        0.6 kB
        Iñaki Arenaza

        Activity

        Hide
        Iñaki Arenaza added a comment -

        Fixed in CVS. Closing now.

        Show
        Iñaki Arenaza added a comment - Fixed in CVS. Closing now.
        Hide
        Nicolas Martignoni added a comment -

        Verified on 1.9beta3, closing.

        Show
        Nicolas Martignoni added a comment - Verified on 1.9beta3, closing.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: