Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12440

Add get_title() to auth base class

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9, 2.0
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      I propose adding the following method to the auth base class:
      /**

      • Return the properly translated human-friendly title of this auth plugin
        */
        function get_title()

      This places responsibility for working out the auth plugin's title within the auth plugin object, rather than having the code to do so in other places. This could also reduce code reuse. There would be little need for sub-classes to overload the method.

      The attached patch adds the function, and replaces the code in admin/auth.php with a call to the new function.

        Attachments

          Activity

            People

            Assignee:
            mjollnir Penny Leach
            Reporter:
            lukehudson Luke Hudson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08