Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12523

cleanup_contexts() broken SQL - breaks upgrades

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9
    • Component/s: Roles / Access
    • Labels:
      None
    • Database:
      Oracle
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      accesslib:cleanup_contexts() - Fix invalid SQL syntax and reserved keywords

      cleanup_contexts() was not working on Oracle - mostly due to 2 SQL
      syntax problems. So probably marginally working elsewhere.

      • We should not use AS when naming table/subselect aliases - only
        when referring to column aliases in the resultset
      • level is a reserved word - oops! - so back to contextlevel

      This was breaking upgrades to 1.9 on Oracle.

        Attachments

          Activity

            People

            • Assignee:
              martinlanghoff Martín Langhoff
              Reporter:
              martinlanghoff Martín Langhoff
              Tester:
              Nobody
              Participants:
              Component watchers:
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Mar/08