Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12531

Add "institution" to lockable fields (admin/auth_config.php)

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.3, 1.9
    • Fix Version/s: 1.9.1, 2.0
    • Component/s: Administration
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      You can lock some user fields from edition by the user at /admin/auth_config.php?auth=manual. These fields are:

      "firstname", "lastname", "email", "phone1", "phone2", "department", "address", "city", "country", "description", "idnumber", "lang"

      It would be logical to enable locking not only institution department, but the institution too (before "department").

      The patch is trivial (see attachment). It works well for me.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Can you, please, Cai?

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Can you, please, Cai?
              Hide
              skodak Petr Skoda added a comment -

              verified closing

              Show
              skodak Petr Skoda added a comment - verified closing
              Hide
              roal Robert Allerstorfer added a comment -

              There has already been MDL-12405 opened for this for a while. The added institution field does not work for me on Moodle 1.8.4+ as a Data mapping field.

              Show
              roal Robert Allerstorfer added a comment - There has already been MDL-12405 opened for this for a while. The added institution field does not work for me on Moodle 1.8.4+ as a Data mapping field.
              Hide
              roal Robert Allerstorfer added a comment -

              This issue must be reopened. The "Improvement" was in fact an introduction of a bug. Just checked it with both the latest 1.8.4+ and 1.9+ versions.

              Show
              roal Robert Allerstorfer added a comment - This issue must be reopened. The "Improvement" was in fact an introduction of a bug. Just checked it with both the latest 1.8.4+ and 1.9+ versions.
              Hide
              roal Robert Allerstorfer added a comment -

              I have posted a patch against MOODLE_19_STABLE CVS to fix this bug and also add the ability to lock/map the Web Page at MDL-12405.

              Show
              roal Robert Allerstorfer added a comment - I have posted a patch against MOODLE_19_STABLE CVS to fix this bug and also add the ability to lock/map the Web Page at MDL-12405 .
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Hi,

              I've seen this an seems correct.

              Anyway... instead of duplicating the list of fields on each auth plugin... what if you declare the list in the auth_plugin_base class as an attribute...? That way the list will be share by all the auth plugins (that are extensions of the base class). And we only will need to modify the base to get all them working in the rest.

              Just a suggestion... ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Hi, I've seen this an seems correct. Anyway... instead of duplicating the list of fields on each auth plugin... what if you declare the list in the auth_plugin_base class as an attribute...? That way the list will be share by all the auth plugins (that are extensions of the base class). And we only will need to modify the base to get all them working in the rest. Just a suggestion... ciao
              Hide
              jerome Jérôme Mouneyrac added a comment -

              I reopened because I'm not sure if dongsheng saw Eloys comment.
              DS, if you don't change anything in the code, close directly this issue. I tested it worked.
              Thanks.

              Show
              jerome Jérôme Mouneyrac added a comment - I reopened because I'm not sure if dongsheng saw Eloys comment. DS, if you don't change anything in the code, close directly this issue. I tested it worked. Thanks.
              Hide
              dongsheng Dongsheng Cai added a comment -

              I saw Eloy's comment, you can find the changes here: http://cvs.moodle.org/moodle/lib/authlib.php?r1=1.12&r2=1.13

              Show
              dongsheng Dongsheng Cai added a comment - I saw Eloy's comment, you can find the changes here: http://cvs.moodle.org/moodle/lib/authlib.php?r1=1.12&r2=1.13

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    15/May/08